[#32757] - [4.0] Better css for frontend edit buttons
- Fixed in Code Base
- 22 Mar 2021
- Medium
- Build: 4.0-dev
- # 32757
- Diff
- rdeutz:fix_32170
User tests: Successful: Unsuccessful:
Pull Request for Issue #32170 .
Summary of Changes
A bit better css for the edit buttons, I made the background half transparent and made the "Edit" text sr-only.
Testing Instructions
- apply patch
- node build/build.js --compile-css templates/cassiopeia/scss
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
LTR
RTL
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Front End Templates (site) NPM Change |
It's a bit hard to tell from your screenshots but it looks like the issue with the placement of the breadcrumbs module edit link is not resolved.
In screenshot 1 it is in the wrong place on the far right
In screenshot 2 I cant see it at all
PS I had been thinking of a different approach but I havent had the time to go further with it and I doubt I will for some time.
Instead of the links/buttons being visible all the time we have a toggle button to display them. A bit like the accessibility plugin
rtl
| Labels |
Added:
NPM Resource Changed
?
?
|
||
@infograf768 can you have a look at the rtl if my change does the trick, I don't have a site with rtl languages, seems they are all not ready for 4
It's a bit hard to tell from your screenshots but it looks like the issue with the placement of the breadcrumbs module edit link is not resolved.
It's not, it is in the top right corner. Don't seen atm how we can fix this with css.
@infograf768 can you have a look at the rtl if my change does the trick, I don't have a site with rtl languages, seems they are all not ready for 4
Persian is ready. Or just set change 0 in the active langmetadat.xml
| Labels |
Added:
?
Removed: ? |
||
Ready to test, should now work.
Nearly there.
Tested with the sample data (not the testing data)
- Breadcrumbs is now in the correct place
- Link in the top right - expected it to be the search module. It was actually the bottom menu module. Looks to be caused by the absolute positioning.
- The edit link for the search module is actually underneath (and therefore not selectable) the bottom menu module link. Again because of the absolute positioning
| Labels |
Added:
?
Removed: ? |
||
Link in the top right - expected it to be the search module. It was actually the bottom menu module. Looks to be caused by the absolute positioning.
fixed
The edit link for the search module is actually underneath (and therefore not selectable) the bottom menu module link. Again because of the absolute positioning
fixed
Lastest articles is still top right (and the tooltip is bottom right)
mod_custom is also hidden in the top right
| Labels |
Added:
?
Removed: ? |
||
Next iteration to catch all modules.
| Labels |
Added:
?
Removed: ? |
||
I have tested this item
Looks much better now.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32757.
richard67
- | Title |
|
||||||
I have tested this item
Tested with blog sample data.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32757.
| Status | Pending | ⇒ | Ready to Commit |
Set to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32757.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-22 13:34:39 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
Removed: ? |
||
Thanks
Are you sure that
sr-onlyis correct?I think in Boostrap 5 we should use
visually-hiddenhttps://getbootstrap.com/docs/5.0/getting-started/accessibility/