? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
20 Mar 2021

Pull Request for Issue #32694 and #17515

Summary of Changes

make calendar.js trigger "change" event when user select new date

Testing Instructions

Apply path, run npm install,
add to Atum index.php:

<script type="module">
if (window.jform_publish_up){
  window.jform_publish_up.addEventListener('change', () => {
    console.log('change');
  })
}
</script>

Go to Article editing, and try to change the publish_up date.
In browser console you should get "change" message on each change

Actual result BEFORE applying this Pull Request

No message

Expected result AFTER applying this Pull Request

Message

Documentation Changes Required

none

avatar Fedik Fedik - open - 20 Mar 2021
avatar Fedik Fedik - change - 20 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2021
Category JavaScript Repository NPM Change
avatar alikon
alikon - comment - 20 Mar 2021

isn't #17515 a j3 issue?

avatar Fedik
Fedik - comment - 20 Mar 2021

yes, there will be one more PR for j3, not that fast ?

avatar Fedik
Fedik - comment - 20 Mar 2021

for jooml3 is there #32756

avatar joomdonation joomdonation - test_item - 20 Mar 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 20 Mar 2021

I have tested this item successfully on be49d16


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32755.

avatar alikon alikon - test_item - 21 Mar 2021 - Tested successfully
avatar alikon
alikon - comment - 21 Mar 2021

I have tested this item successfully on be49d16


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32755.

avatar alikon alikon - change - 21 Mar 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 21 Mar 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32755.

avatar Quy Quy - change - 21 Mar 2021
Labels Added: ? ?
avatar rdeutz rdeutz - close - 22 Mar 2021
avatar rdeutz rdeutz - merge - 22 Mar 2021
avatar rdeutz rdeutz - change - 22 Mar 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-22 06:22:32
Closed_By rdeutz
Labels

Add a Comment

Login with GitHub to post a comment