[#32746] - [4.0] Irrelevent portions of code removed
- Fixed in Code Base
- 19 Mar 2021
- Medium
- Build: 4.0-dev
- # 32746
- Diff
- saumyasarkar11:patch-6
User tests: Successful: Unsuccessful:
Pull Request for Issue #32725 .
Summary of Changes
-
&& $this->item->pagination removed from https://github.com/joomla/joomla-cms/blob/4.0.0-beta7/components/com_content/tmpl/article/default.php#L43.
-
Brackets around OR removed from https://github.com/joomla/joomla-cms/blob/4.0.0-beta7/components/com_content/tmpl/article/default.php#L49-L51.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-19 11:21:36 |
| Closed_By | ⇒ | saumyasarkar11 |
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-03-19 11:21:36 | ⇒ | |
| Closed_By | saumyasarkar11 | ⇒ |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32746.
I have tested this item successfully on e0f22cf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32746.
Is it RTC now?
Is it RTC now?
PRs need 2 successful tests before they go RTC. Always tests of others.
Thank you! Small changes with great effort ;-)
Is it RTC now?
PRs need 2 successful tests before they go RTC. Always tests of others.
Thank you! Small changes with great effort ;-)
Welcome!
I wonder why we don't make the same change (remove && $this->item->pagination) on the other lines on same file ?
https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_content/tmpl/article/default.php#L117
https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_content/tmpl/article/default.php#L139
I wonder why we don't make the same change (remove && $this->item->pagination) on the other lines on same file ?
Agree. I forgot to mention that. Just noted in in my todo...
@saumyasarkar11 can you please do the requested changes #32746 (comment) too
Some testing instructions would be required. We have the corresponding head lines in the template for our pull requests not without a reason.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32746.
Some testing instructions would be required.
Code review should be sufficient. See also description in issue #32725 (comment)
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32746.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32746.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-19 14:49:29 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
|
||
Thanks @saumyasarkar11 and congratulations to your first merged PR in Joomla
So @ReLater according to you, this is the correct one?