[#32745] - [4.0] Irrelevent Codes and Comments removed
- Closed
- 19 Mar 2021
- Medium
- Build: 4.0-dev
- # 32745
- Diff
- saumyasarkar11:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue #32725.
Summary of Changes
-
&& $this->item->pagination removed from https://github.com/joomla/joomla-cms/blob/4.0.0-beta7/components/com_content/tmpl/article/default.php#L43.
-
Comment and brackets around OR removed from https://github.com/joomla/joomla-cms/blob/4.0.0-beta7/components/com_content/tmpl/article/default.php#L49-L51.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-19 10:43:47 |
| Closed_By | ⇒ | saumyasarkar11 | |
| Labels |
Added:
?
|
||
As stated in the issue, the comment should be there, it should not be removed
That's wrong. In the issue.
I think it's there from an older version, can be removed
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-03-19 10:43:47 | ⇒ | |
| Closed_By | saumyasarkar11 | ⇒ |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32745.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32745.
I have tested this item unsuccessfully on 7c10476
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32745.
Can you just elaborate on this.....Would be helpful
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-19 11:30:51 |
| Closed_By | ⇒ | saumyasarkar11 |
Your PR contains more changes than needed. You should make PR base on the code of latest 4.0-dev branch: