User tests: Successful: Unsuccessful:
Add new unit test to cover b/c and security fixes in 3.9.25/26
THIS TEST IS DESIGNED TO PASS BASED ON THE CURRENT STATE OF STAGING. This is AFTER 3.9.25 was released and BEFORE @richard67 fixes to b/c therefore MORE tuning might be required to the rules after the b/c issues are resolved.
Its a unit test. Run the unit tests and see if they pass :)
No test.
A test that passes.
none.
Status | New | ⇒ | Pending |
Category | ⇒ | Unit Tests |
Labels |
Added:
?
?
|
Title |
|
@PhilETaylor Would it make sense to add some test cases for e.g. Cyrillic or Greece names, e.g. Изображений
and Εικόνες
?
And regarding numbers I am missing some with a number as first character. Your examples with numbers all start with /
.
Labels |
Added:
?
Removed: ? |
array(false, $xml, '.images'),
array(false, $xml, './images'),
array(false, $xml, '.\images'),
array(false, $xml, '../images'),
array(false, $xml, '.../images'),
array(true, $xml, 'c:\images'),
array(false, $xml, '\\images'), // Means \images
array(true, $xml, 'ftp://images'),
array(true, $xml, 'http://images'),
array(false, $xml, '/media'),
array(false, $xml, '/administrator'),
array(false, $xml, '/4711images'),
array(false, $xml, '4711images'),
array(false, $xml, '1'),
array(false, $xml, '_'),
array(false, $xml, '*'),
array(false, $xml, '%'),
array(false, $xml, '://foo'),
array(false, $xml, '/4711i/images'),
array(false, $xml, '../4711i/images'),
array(false, $xml, 'Εικόνες'),
array(false, $xml, 'Изображений'),
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.
Warning: The Xdebug extension is not loaded
No code coverage will be generated.
......................
Time: 67 ms, Memory: 8.00MB
OK (22 tests, 22 assertions)
@PhilETaylor On Linux test are passing:
richard@vmkubu02:~/lamp/public_html/joomla-cms$ ./libraries/vendor/phpunit/phpunit/phpunit tests/unit/suites/libraries/cms/form/rule/FilePathRuleTest.php
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.
Warning: The Xdebug extension is not loaded
No code coverage will be generated.
.......................
Time: 59 ms, Memory: 8.00MB
OK (23 tests, 23 assertions)
User deprecation notices (138)
JError::setErrorHandling() is deprecated: 138x
69x in FilePathRuleTest::setUp
69x in FilePathRuleTest::tearDown
richard@vmkubu02:~/lamp/public_html/joomla-cms$
Windows I haven't tested (yet).
Windows I haven't tested (yet).
Well I dont have windows anywhere here but isn't this why we have Drone and AppVeyor?
Thats windows, and the tests are passing there.
Thats windows, and the tests are passing there.
@PhilETaylor You are right, thanks for pointing me to it. I think I need sleep soon ;-)
I have tested this item
Unit tests pass on Linux (drone) and Windows (appveyor).
I've successfully checked the complete loge files in drone and appveyor to verify that the new tests have been run.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-18 06:16:06 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
Removed: ? |
looks like Drones link to composer is broken again - not related to this PR though