Feeling Lucky
?
?
[#32722] - [4.0] Simplify PHP version number to remove vendor suffixes
- Fixed in Code Base
- 18 Mar 2021
- Medium
- Build: 4.0-dev
- # 32722
- Diff
- PhilETaylor:32721
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Closes #32721
Summary of Changes
Simplify PHP 7.2.34-8+ubuntu18.04.1+deb.sury.org+1 to PHP 7.2.34
Testing Instructions
Install PHP 7.2 - visit admin console
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
PhilETaylor
- comment
- 17 Mar 2021
I debated that, lets try $phpVersion as $version is already used as well as $versionData ... dont want to confuse.
| Labels |
Added:
?
|
||
richard67
- comment
- 17 Mar 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32722.
Quy
- comment
- 17 Mar 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32722.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 17 Mar 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32722.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-18 06:33:44 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Looks good to me. From a purely codestyle point of view and to make it easier to read shouldnt the variable ($PHP_VERSION) be lowercase and have a different name to the php internal name of PHP_VERSION ??