? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
15 Mar 2021

Replace PR #31115

Summary of Changes

Better description of list Categories List Views in contact,, news feed and article.

category list

Testing Instructions

Make new menu items for contact, news feed, articles

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

The menu item description is clearer

grafik

avatar chmst chmst - open - 15 Mar 2021
avatar chmst chmst - change - 15 Mar 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Mar 2021
Category Administration Language & Strings
avatar ChristineWk ChristineWk - test_item - 16 Mar 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 16 Mar 2021

I have tested this item successfully on 3f3655d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32698.

avatar rdeutz
rdeutz - comment - 16 Mar 2021

@brianteeman could you have a look at the wording, thanks

avatar sksuryan
sksuryan - comment - 16 Mar 2021

image

Just one question, shouldn't it show "Article Category Tree" in the heading? Because I saw a change specifically for it in administrator/language/en-GB/com_categories.sys.ini if I'm not wrong.

avatar ChristineWk
ChristineWk - comment - 16 Mar 2021

Not sure :-)
Maybe shorted to:
List All Categories in a Category Tree - because "Contacts" already there.

avatar brianteeman
brianteeman - comment - 16 Mar 2021

I prefer consistency but there are two different styles here
"Shows a list of all categories in the selected category tree."
"Shows a list of categories within a contact category tree"

technicaly it is "in" not "within" as it includes the top level item in the tree as within==inside
So can we please change them all to match the first example
ie "Shows a list of all categories in the selected contact category tree."

These two need to be swapped
COM_CONTENT_CATEGORIES_VIEW_DEFAULT_TITLE="List All Categories in a Category Tree"
COM_CATEGORIES_CATEGORIES_VIEW_DEFAULT_TITLE="List All Categories in an Article Category Tree"

avatar brianteeman
brianteeman - comment - 16 Mar 2021

and I agree with @ChristineWk about shortening all the titles

avatar webfeuerflo
webfeuerflo - comment - 16 Mar 2021

I tested it suscessfully with the patchtester on 4.0.0.-beta5

avatar sksuryan
sksuryan - comment - 16 Mar 2021

I think the intention was to keep it clear for the user once they have selected the option. It could be that the option in Article section was missed because Contacts and News feed have it. Rest, @chmst could comment on it better.

avatar chmst chmst - change - 16 Mar 2021
Labels Added: ? ?
avatar chmst
chmst - comment - 16 Mar 2021

Thanks for testing and advice. For articles, contacts and news feeds the strings should follow now the suggestion of @brianteeman

avatar rdeutz rdeutz - change - 16 Mar 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-03-16 13:05:51
Closed_By rdeutz
avatar rdeutz rdeutz - close - 16 Mar 2021
avatar rdeutz rdeutz - merge - 16 Mar 2021

Add a Comment

Login with GitHub to post a comment