[#32697] - Fixes button margin
- Fixed in Code Base
- 16 Mar 2021
- Medium
- Build: 4.0-dev
- # 32697
- Diff
- srishty-07:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
bootstrap margin class was added to the danger button
Testing Instructions
open the cassiopeia page[frontend] on (http://localhost/joomla-cms/index.php?option=com_config&view=modules&id=1&Itemid=101&return=aHR0cDovL2xvY2FsaG9zdC9qb29tbGEtY21zLw%3D%3D)
2)open edit module on the right hand side of the page.
set the toggle device toolbar to mobile view.
4)before applying the patch it would show improper margin between the buttons, but after applying the patch proper margin is there.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
@srishty-07 If you check the details of the failed drone CI step at the bottom of the PR, you will at the end find this log, which tells about the code style error for which I've suggested the correction above: https://ci.joomla.org/joomla/joomla-cms/40731/1/20
thanks @richard67
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697.
@srishty-07 in Cassiopeia we use the breakpoints from Bootstrap, something like @include media-breakpoint-down(md)
You can check the files _footer.scss and _header.scss for examples.
@srishty-07 in Cassiopeia we use the breakpoints from Bootstrap, something like
@include media-breakpoint-down(md)
You can check the files_footer.scssand_header.scssfor examples.
done the required changes @drmenzelit ,kindly check once
@himanshu007-creator @sksuryan Could you test again? The PR has received a change. Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697.
The previous test is still valid because the commit after it which has invalidated it was just a code style change. I've restored the test result so it's properly counted.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-16 17:05:52 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@srishty-07 Congratulations for your first merged pull request here. Now it will be in the next 4.0 Beta version.
@srishty-07 If you check the details of the failed drone CI step at the bottom of the PR, you will at the end find this log, which tells about the code style error for which I've suggested the correction above: https://ci.joomla.org/joomla/joomla-cms/40731/1/20