[#32671] - [4.1] [mod_quickicon] Improvements - more Joomla icons
- Closed
- 13 Jul 2022
- Medium
- Build: 4.0-dev
- # 32671
- Diff
- Bongovo:4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
The mod_quickicon module is the basic Joomla administration module, but it does not contain all the icons for quick access to all the main parts of the administration.
As the main module, these icons should contain!
Newly added icons can be turned off by default. The user will be able to turn them on, or even create a new module with their own selection of icons.
Installed Joomla extensions use the plugin to create their own icons, this option should also be available for core Joomla extensions. It's much easier than creating another module or plugin.
The change will certainly be appreciated by beginners with Joomla, but also by experienced users, for whom the new menu in Joomla 4 is guaranteed to be problematic.
Summary of Changes
complete strings:
administrator\language\en-GB\com_banners.ini
administrator\language\en-GB\com_contact.ini
administrator\language\en-GB\com_content.ini
administrator\language\en-GB\com_languages.ini
administrator\language\en-GB\com_newsfeeds.ini
administrator\language\en-GB\com_tags.ini
administrator\language\en-GB\com_templates.ini
administrator\language\en-GB\mod_quickicon.ini
edit code:
administrator\components\com_banners\src\Controller\BannersController.php
administrator\components\com_contact\src\Controller\ContactsController.php
administrator\components\com_content\src\Controller\FeaturedController.php
administrator\components\com_languages\src\Controller\LanguagesController.php
administrator\components\com_newsfeeds\src\Controller\NewsfeedsController.php
administrator\components\com_tags\src\Controller\TagsController.php
administrator\components\com_templates\src\Controller\StylesController.php
administrator\components\com_templates\src\Controller\TemplateController.php
administrator\modules\mod_quickicon\src\Helper\QuickIconHelper.php
administrator\modules\mod_quickicon\mod_quickicon.xml
The ADD option has been added to all icons (where possible).
A counter display option has been added to all icons (where appropriate).
Download — Prebuilt packages are available for download.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Modules |
Hi,
why not? Every user is different, so let everyone adapt it. I tried it and immediately arranged it so that I had everything at hand. Is the position named mod_quickicon or am I wrong?
I think that's a good idea.
Joomla is a modular system, so let's let each user customize it, or set up a static page after logging in?
@Bongovo congrats to your first PR and thank you for contribution.
Only from inspecting the code it seems that there is some work needed:
- alphaorder the Language keys
- indent carefully all lines (with tabs not spaces)
- workflow makes only sense when workflow is enabled
- language buttons make only sense when it is a mulitlingual site
- did you test the result of your ajax requests?
Additional what Christiane said:
- multilingual is not always enable
- permission checks missing (if the module is updated it should be done correct)
- ...
language buttons make only sense when it is a multilingual site
Nope.
one can have a monolanguage site and use multiple languages for the UI depending on user's choice.
My bad - with language buttons I meant language assiciations, sorry for confusion.
| Labels |
Added:
?
?
?
|
||
I am moving this to 4.1, we are in beta and this is a new feature.
| Title |
|
||||||
| Category | Administration Language & Strings Modules | ⇒ | Administration com_admin SQL Postgresql com_config com_contact com_content com_fields com_menus com_modules com_users com_workflow Language & Strings Modules Templates (admin) NPM Change JavaScript Repository |
Where appropriate you should add the count option to the new icons
The "Site" quickicons module was meant to provide quick links (and counters if possible) for things related to create content for the site (frontend). That's why it has title "Site". The proposal here adds quickicons also for things not related to or limited to site content, e.g. "Languages". That seems odd to me or at least against the original idea for that "Site" quickicons module.
The "Site" quickicons module was meant to provide quick links (and counters if possible) for things related to create content for the site (frontend). That's why it has title "Site". The proposal here adds quickicons also for things not related to or limited to site content, e.g. "Languages". That seems odd to me or at least against the original idea for that "Site" quickicons module.
There is only one module and it is used differently according to settings and Groups (site_quickicon, system_quickicon, ...). Site, System, Notifications ... are only the titles of the modules that will contain them on the user.
There is only one module and it is used differently according to settings and Groups (site_quickicon, system_quickicon, ...). Site, System, Notifications ... are only the titles of the modules that will contain them on the user.
That still doesn't mean that it makes sense to add "Languages" below the title "Site".
That still doesn't mean that it makes sense to add "Languages" below the title "Site".
@richard67 You misunderstood @Bongovo
All three current dashboard modules are the same module just with different icons selected. The screenshot is misleading you as it is showing all the icons in one module but it wouldnt have to.
PS I am more convinced now about this PR. Just would like to see "add new" and "count" options added where appropriate
I see.
PS I am more convinced now about this PR. Just would like to see "add new" and "count" options added where appropriate
"Add" edits are complete. "Count" adjustments are in progress.
See screen.
Icons displayed without the "Add" function cannot be supplemented by this direct function. Another user step is required.
When done, I will upload the newly modified files.
| Labels |
Added:
NPM Resource Changed
?
?
Removed: ? ? |
||
| Category | Administration Language & Strings Modules com_admin SQL Postgresql com_config com_contact com_content com_fields com_menus com_modules com_users com_workflow Templates (admin) NPM Change JavaScript Repository | ⇒ | Administration com_admin SQL Postgresql com_banners com_config com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_tags com_templates com_users com_workflow Language & Strings |
| Labels |
Added:
?
Removed: NPM Resource Changed ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Category | Administration Language & Strings com_admin SQL Postgresql com_config com_contact com_content com_fields com_menus com_modules com_users com_workflow com_banners com_languages com_newsfeeds com_tags com_templates | ⇒ | Administration com_admin SQL Postgresql com_banners com_config com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_templates com_users com_workflow Language & Strings |
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
All bugs have been fixed. It looks like it is possible to download the package and try the Quick icons module.
| Labels |
Removed:
?
|
||
| Category | Administration Language & Strings com_admin SQL Postgresql com_config com_contact com_content com_fields com_menus com_modules com_users com_workflow com_banners com_languages com_newsfeeds com_templates | ⇒ | Administration com_admin SQL Postgresql com_banners com_config com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_tags com_templates com_users com_workflow Language & Strings |
| Labels |
Added:
Language Change
?
Removed: ? ? |
||
Something not right with this PR. Its also deleting Post Installation Messages from com_admin??
Thanks @PhilETaylor for the quick fixes, I merged, so we can concentrate on the PR functions.
@Bongovo could you please check and see what happened with the conflicts and the extra files?
It would be really good to get this deconflicted and merged
This pull request has automatically rebased to 4.2-dev.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-07-13 12:02:23 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
Ready to take over
Conflicting Files
|
||
| Category | Administration Language & Strings com_admin SQL Postgresql com_config com_contact com_content com_fields com_menus com_modules com_users com_workflow com_banners com_languages com_newsfeeds com_templates com_tags | ⇒ | Unit Tests Administration com_banners com_contact com_content com_languages com_newsfeeds com_tags com_templates com_users Language & Strings Modules Libraries Front End Plugins |
This pr moves AWAY from the fontawesome work done last year. The whole purpose was to move towards complete FA only icons not to encourage more joomla-icon usage
Why, Why, Why