[#32670] - [4.0][a11y] fixes intended labels not being shown for search in searchtools
- Fixed in Code Base
- 14 Mar 2021
- Medium
- Build: 4.0-dev
- # 32670
- Diff
- sksuryan:fix_searchtools_search_label
User tests: Successful: Unsuccessful:
Summary of Changes
Removes this particular redundant condition, since this condition always failed and hence the actual labels were never rendered.
Further, this condition was being used as a fallback in case there wasn't any label present. But no fallback was actually required since in case there wasn't any label defined, it was already set to the default "search".
Also, $filters['filter_search']->label isn't a label value, rather an html label element.
joomla-cms/layouts/joomla/searchtools/default/bar.php
Lines 42 to 48 in e317fe2
Testing Instructions
- Login to Administrator.
- In content category, go to articles.
- Use dev tools to select the search bar.
- Look for the
labelelement below theinputfield.
This could be tested in other categories as well which uses search from layouts/joomla/searchtools.
Actual result BEFORE applying this Pull Request
Default "search" label is displayed.
Expected result AFTER applying this Pull Request
Actual label should be displayed.
Discovered this issue through PR #32660.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32670.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32670.
richard67
- | Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-14 15:47:05 |
| Closed_By | ⇒ | chmst | |
| Labels | |||
Thanks!
Welcome!
I have tested this item✅ successfully on 14bcf96
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32670.