Feeling Lucky
NPM Resource Changed
?
?
[#32657] - [4.0] fixes missing search message for no result found
- Fixed in Code Base
- 13 Mar 2021
- Medium
- Build: 4.0-dev
- # 32657
- Diff
- sksuryan:fix_no_module_search_message
User tests: Successful: Unsuccessful:
Pull Request for Issue #31351 .
Summary of Changes
This PR adds a alert message for when a module is not found in search while selecting a new module in Administrator or Site section.
It adds a div for alert in administrator/components/com_modules/tmpl/select/default.php and adds the code to count the number of modules that are currently shown in build/media_source/com_modules/js/admin-module-search.es6.js. If the count turns to zero or less than that, an alert is shown.
Testing Instructions
- Login to admin panel
- Go to Site/administrator modules
- Click on New module
- Search the module name which is not present
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
joomdonation
- comment
- 13 Mar 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32657.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 13 Mar 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32657.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-13 10:15:31 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
richard67
- comment
- 13 Mar 2021
Thanks!
sksuryan
- comment
- 13 Mar 2021
Thank you @richard67! I'm really loving the community. More contributions coming soon!
I have tested this item✅ successfully on fc4e050
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32657.