[#32624] - [4.0] Fix modal not opening in subfield
- Fixed in Code Base
- 16 Mar 2021
- Medium
- Build: 4.0-dev
- # 32624
- Diff
- Quy:subfield-modal
User tests: Successful: Unsuccessful:
Pull Request for Issue #26711 and #28953.
Thanks @dgrammatiko for the code.
Testing Instructions
Install patch and npm run build:js
or
Download installer package.
Create 2 custom fields: Media and User
Create a subfield consisting these 2 custom fields.
Edit an article.
Go to Fields tab.
Add a row.
Click Select button.
Click User icon.
Actual result BEFORE applying this Pull Request
Modal doesn't open.
Expected result AFTER applying this Pull Request
Modal opens.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32624.
| Labels |
Added:
NPM Resource Changed
?
|
||
This resolves the issue for media and user fields but the problem still exists for other modals eg article select
This resolves the issue for media and user fields but the problem still exists for other modals eg article select
What's the problem with them? This is an issue due to the way subforms work and the fact that some fields have still dependency on Bootstrap modal. The other modals are tightly connected only to editors...
there is no content in the modal. Just the header and footer
URL?
will send it privately
scrub - that. I must have had a typo or something. Its working now
I was wrong - its not working but it is unrelated - sorry for the confusion on this PR
I have tested this item
Tested successfully with media and user fields
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32624.
However it does NOT solve the issue for other modal fields such as administrator/components/com_content/src/Field/Modal/ArticleField.php
I'm guessing there needs to be a patch for modal-field.js
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32624.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32624.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-16 17:55:19 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on aacd7ea
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32624.
Thx