[#32602] - [4.0] Remove jQuery dependency for com_joomlaupdate Pre-Update Check
- Fixed in Code Base
- 21 Mar 2021
- Medium
- Build: 4.0-dev
- # 32602
- Diff
- joomdonation:com_joomlaupdate_removejquery
User tests: Successful: Unsuccessful:
Pull Request for part of Issue #31490.
Summary of Changes
My attempt to remove jQuery dependency for com_joomlaupdate Pre-Update Check.
Testing Instructions
- Login to administrator area of your site. Access to Joomla Update component (System -> Update -> Joomla) with this URL http://localhost/joomla4/administrator/index.php?option=com_joomlaupdate (replace http://localhost/joomla4/administrator/ with administrator URL of your site)
- Click on Options button in the toolbar
- Set Update Channel to Custom URL
- Set Minimum Stability to Beta
- Set Custom URL to https://update.joomla.org/core/nightlies/next_major_list.xml
-
Install an old version of an extension you know that there is new update available. I would suggest you to install this old version of Akeeba Backup extension which can be downloaded from this URL https://www.akeeba.com/download/akeeba-backup/8-0-1/pkg_akeeba-8-0-1-core-zip.zip
-
Get the attached zip file (it contains complied javascript files comes from this PR), unzip it to the folder media of your site (it will replace the current javascript code in media/com_joomla update folder)
com_joomlaupdate.zip -
Come back to Joomla Update Screen, press Check for Updates button, confirm that you see a screen like below telling you that there are Joomla update available and extensions compatible with that update.
- Click on [ More Detail ] text, confirm that you will see more for the table Displayed and the text will be changed to [Less Detail]
- Click again on [Less Detail], confirm that some columns are hidden in the table and the text changed back to [More Detail] like before
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Title |
|
||||||
- This is my first PR modify JS code. Not sure what we need to do have the changes to JS applied to testing site. Could @richard67 helps with some instructions here?
If you have a development environment with composer and npm, you can "compile" (i.e. copy, transpile, minify) the JS as described here: https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment
Testers who don't have npm can use the installation package built by our drone CI job to make a new installation, or the update package or custom update URL to update a J4 without the PR to the PR (but then there's no way back). These packages can be found by expanding the "Show all checks" at the bottom of the PR and the using the "Details" link at the right side of the "Download" step.
| Labels |
Added:
NPM Resource Changed
?
|
||
@dgrammatiko Thanks. I renamed the file as instructed. For taking the source directly from 3.10, I think we should not do that for now because I it is different with the source from 4.0-dev (I think @wilsonge had made some adjustment to fix some bugs with 4.0-dev before).
@joomdonation The JS linter complains about tabs: https://ci.joomla.org/joomla/joomla-cms/40530/1/21
Run npm run lint:js
copy the eslint... from the cli and add after the last dot a space and the —fix
This will fix most cs automatically
Edit the command is:
eslint --config build/.eslintrc --ignore-pattern '/media/' --ext .es6.js,.es6,.vue . --fix
@joomdonation use this (remove the.txt):
update.es6.js.txt
Again javascript code style: https://ci.joomla.org/joomla/joomla-cms/40545/1/21
I updated the PR with a more clear testing instructions. Hopefully testers can follow instructions to test now.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-21 23:17:13 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I did some basic testing of this and it seemed to work fine for me in Chrome OSX. I'm merging this so we get wider testing exposure. Thankyou!
Couple of things: rename the file to?
.es6.jsto get the lint work on that. I was supposed to do this work... also you might want to take the source directly from 3.10 and then do transformation (I’m not sure if the version here is the same as the one in 3.10). One more thing, thanks