No Code Attached Yet
avatar infograf768
infograf768
6 Mar 2021

See #32592 (comment)

Quoting and please forget the hate...

You cannot update the extra_query after an update has been discovered

Files are not copied on update

OPcache problem

avatar infograf768 infograf768 - open - 6 Mar 2021
avatar joomla-cms-bot joomla-cms-bot - change - 6 Mar 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 6 Mar 2021
avatar ssnobben
ssnobben - comment - 7 Mar 2021

Thks Grandpa taking care of the babies.

avatar PhilETaylor
PhilETaylor - comment - 28 Mar 2021

You cannot update the extra_query after an update has been discovered

Is addressed here #32862

avatar PhilETaylor
PhilETaylor - comment - 28 Mar 2021

OPcache problem

For Joomla 4 is here #32915

For Joomla 3 is here #32918

For joomla-fframework/filesystem here joomla-framework/filesystem#37

avatar richard67
richard67 - comment - 1 Apr 2021

@PhilETaylor I hope you know that Sharky doesn't have any right to speak for the JBS or for maintainers. He seems to perform his private war here. So please don't let him influence your motivation for your PR's.

avatar PhilETaylor
PhilETaylor - comment - 1 Apr 2021

I will use have used official channels to escalate this to OSM. Who I fully expect to do nothing. As they have done for every single CoC issue I have raised. @jeckodevelopment

avatar jeckodevelopment
jeckodevelopment - comment - 3 Apr 2021

Hi @PhilETaylor calling @marcodings here as the relevant DC.

avatar richard67
richard67 - comment - 3 Apr 2021

@jeckodevelopment @marcodings More information on what the problem was can be found in this PR: #32915 . You have to expand the comments which are meanwhile hidden on GitHub by default due to the long history. You can also ask me on Glip for details.

avatar PhilETaylor
PhilETaylor - comment - 3 Apr 2021

due to the long history.

Which is me actually trying to get this right and get it all merged as the opcache issues are valid issues already addressed by all other major cms. And thank you for @richard67 for his timely feedback and time taken to actually understand and test the issues involved.

As for the Shark attacks, the bites drew blood and left scars... but the shark should never have been in my paddling pool.

avatar richard67
richard67 - comment - 3 Apr 2021

Good we have no piranhas here ;-)

avatar brianteeman
brianteeman - comment - 25 Apr 2021

Is there anything left to do here?

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

Yes. The "Files are not copied on update" which still needs doing/testing/debugging/fixing

avatar richard67
richard67 - comment - 25 Apr 2021

... if we will ever be able to reproduce it. As far as I understand, that seems to be not easy.

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

Im kind of hoping it was an opcache thing, but re-reading Nic's explanation Im now not sure. Like you said it seems hard to replicate, so my plan (Before I was sidetracked with he FTP Layer) was to write the code to compare each files checksum after installation and to DIE if the checksum was different (for now just DIE and report the findings, and not actually rewrite the file again like Nic's workaround does) - and publish that as a PR so people could hammer it on some sites, and see if we could then replicate it...

If we can then replicate it - by using the the PR that DIES if the hash of the files in the package are different to the hash of the file on the hard drive - then at least we have something to look at further. Even better if it only happens sometimes. Even better if its reproducible on demand.

DIES = Tell the user somehow.

avatar richard67
richard67 - comment - 25 Apr 2021

That sounds like a good plan.

avatar infograf768 infograf768 - change - 28 Jun 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-06-28 07:43:04
Closed_By infograf768
Labels Added: No Code Attached Yet
Removed: ?
avatar infograf768 infograf768 - close - 28 Jun 2022

Add a Comment

Login with GitHub to post a comment