[#32596] - Add iframe lazyloading to the core wrapper feature
- Fixed in Code Base
- 17 Mar 2021
- Medium
- Build: 4.0-dev
- # 32596
- Diff
- zero-24:lazyloadiframes4
User tests: Successful: Unsuccessful:
Summary of Changes
Add iframe lazyloading to the core wrapper feature
Testing Instructions
Create an iframe wrapper via the component (example: https://www.youtube.com/embed/tgbNymZ7vqY)
Create an iframe wrapper with the module
Check the html code and make sure the loading attribute is set (loading=lazy)
Disable the lazy loading option
Check the html code and make sure the loading attribute is set (loading=eager)
Actual result BEFORE applying this Pull Request
There is no option to set the lazyloading attribute
Expected result AFTER applying this Pull Request
There is a option to set the lazyloading attribute
cc @bembelimen
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End com_wrapper Modules |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32596.
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32596.
Why not using directly "lazy" and "eger" as option values? Then you can skip the ternary operators.
Why not using directly "lazy" and "eger" as option values? Then you can skip the ternary operators.
Arent that values (0 + 1) bound to the CSS for the switcher?
Arent that values (0 + 1) bound to the CSS for the switcher?
No. It can be any values.
| Status | Ready to Commit | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32596.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32596.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32596.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-17 10:50:08 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 5308355
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32596.