[#32467] - [4.0] Cassiopeia variables
- Fixed in Code Base
- 24 Feb 2021
- Medium
- Build: 4.0-dev
- # 32467
- Diff
- brianteeman:cass
User tests: Successful: 2 ceford, drmenzelit Unsuccessful: 0
This PR cleans up the scss variables being used in cassiopeia - the less we change the easier it is to maintain when upstream changes and we dont miss out on features such as rfs and xxl
- grid breakpoints - removed no reason to override
- grid containers - removed no reason to override
- font-sizes - removed so that we can have responsive fonts sizes which are a key feature of bootstrap 5
- tables - removed two variables that are identical to upstream. had to keep one of them as it is used in this file
- list-group - removed as identical to upstream
z-index also needs to be reviewed but thats for another PR as is doing the same review for atum.
all the other cassiopeia overrides need to be checked as well to make sure they are not overriding things that it doesnt need to. This is just a start that I hope some people with more frontend skills can continue in another pr
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
Check that it compiles and check the typography page of the sample data
Someone with better frontned skills than me needs to ensure that the changes from em back to the bootstrap grid and font sizes are the same.
@drmenzelit Could you have a look on it? And eventually also close your PR #32446 in favour of this and possible future fixes for removing overrides of BS SCSS in Cassiopeia? Thanks in advance. I know it was not your idea to override all the BS stuff in Cassiopeia.
The changes from Brian are fine, I don't see changes in the layout. But in my PR were 2 changes that we can need:
templates/cassiopeia/scss/blocks/_layout.scss and
templates/cassiopeia/scss/blocks/_css-grid.scss
Maybe can my PR be merged first and then this one. Brian only changes variables.scss
| Labels |
Added:
NPM Resource Changed
?
|
||
The changes from Brian are fine, I don't see changes in the layout. But in my PR were 2 changes that we can need:
templates/cassiopeia/scss/blocks/_layout.scss and
templates/cassiopeia/scss/blocks/_css-grid.scss
Maybe can my PR be merged first and then this one. Brian only changes variables.scss
@drmenzelit I've merged your PR and than have solved the conflict in _variables.scss here resulting from that merge. I hope the latter will help with @brianteeman not biting me.
@richard67 in future I would prefer it if you didnt merge anything into my pr as it breaks my workflow
@brianteeman Ok, noticed. Just thought it would help.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32467.
I have tested this item
Compiles successfully and I see the heading font sizes change - a tad larger with the patch applied. Looks OK.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32467.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32467.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-24 04:36:42 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Thanks!
thanks
Testing instructions are "Check that the site looks as well as before"?