NPM Resource Changed ? ?

Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 Feb 2021

This PR cleans up the scss variables being used in cassiopeia - the less we change the easier it is to maintain when upstream changes and we dont miss out on features such as rfs and xxl

  • grid breakpoints - removed no reason to override
  • grid containers - removed no reason to override
  • font-sizes - removed so that we can have responsive fonts sizes which are a key feature of bootstrap 5
  • tables - removed two variables that are identical to upstream. had to keep one of them as it is used in this file
  • list-group - removed as identical to upstream

z-index also needs to be reviewed but thats for another PR as is doing the same review for atum.
all the other cassiopeia overrides need to be checked as well to make sure they are not overriding things that it doesnt need to. This is just a start that I hope some people with more frontend skills can continue in another pr

avatar brianteeman brianteeman - open - 20 Feb 2021
avatar brianteeman brianteeman - change - 20 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Feb 2021
Category Front End Templates (site) NPM Change
avatar brianteeman brianteeman - change - 20 Feb 2021
The description was changed
avatar brianteeman brianteeman - edited - 20 Feb 2021
avatar richard67
richard67 - comment - 20 Feb 2021

Testing instructions are "Check that the site looks as well as before"?

avatar brianteeman
brianteeman - comment - 20 Feb 2021

Check that it compiles and check the typography page of the sample data

avatar brianteeman brianteeman - change - 20 Feb 2021
The description was changed
avatar brianteeman brianteeman - edited - 20 Feb 2021
avatar brianteeman
brianteeman - comment - 21 Feb 2021

Someone with better frontned skills than me needs to ensure that the changes from em back to the bootstrap grid and font sizes are the same.

avatar richard67
richard67 - comment - 21 Feb 2021

@drmenzelit Could you have a look on it? And eventually also close your PR #32446 in favour of this and possible future fixes for removing overrides of BS SCSS in Cassiopeia? Thanks in advance. I know it was not your idea to override all the BS stuff in Cassiopeia.

avatar drmenzelit
drmenzelit - comment - 21 Feb 2021

The changes from Brian are fine, I don't see changes in the layout. But in my PR were 2 changes that we can need:
templates/cassiopeia/scss/blocks/_layout.scss and
templates/cassiopeia/scss/blocks/_css-grid.scss
Maybe can my PR be merged first and then this one. Brian only changes variables.scss

avatar richard67 richard67 - change - 21 Feb 2021
Labels Added: NPM Resource Changed ?
avatar richard67
richard67 - comment - 21 Feb 2021

The changes from Brian are fine, I don't see changes in the layout. But in my PR were 2 changes that we can need:
templates/cassiopeia/scss/blocks/_layout.scss and
templates/cassiopeia/scss/blocks/_css-grid.scss
Maybe can my PR be merged first and then this one. Brian only changes variables.scss

@drmenzelit I've merged your PR and than have solved the conflict in _variables.scss here resulting from that merge. I hope the latter will help with @brianteeman not biting me.

avatar brianteeman
brianteeman - comment - 21 Feb 2021

@richard67 in future I would prefer it if you didnt merge anything into my pr as it breaks my workflow

avatar richard67
richard67 - comment - 21 Feb 2021

@brianteeman Ok, noticed. Just thought it would help.

avatar drmenzelit drmenzelit - test_item - 21 Feb 2021 - Tested successfully
avatar drmenzelit
drmenzelit - comment - 21 Feb 2021

I have tested this item successfully on 6770f52


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32467.

avatar ceford ceford - test_item - 22 Feb 2021 - Tested successfully
avatar ceford
ceford - comment - 22 Feb 2021

I have tested this item successfully on 6770f52

Compiles successfully and I see the heading font sizes change - a tad larger with the patch applied. Looks OK.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32467.

avatar richard67 richard67 - change - 22 Feb 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 22 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32467.

avatar laoneo laoneo - close - 24 Feb 2021
avatar laoneo laoneo - merge - 24 Feb 2021
avatar laoneo laoneo - change - 24 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-24 04:36:42
Closed_By laoneo
Labels Added: ?
avatar laoneo
laoneo - comment - 24 Feb 2021

Thanks!

avatar brianteeman
brianteeman - comment - 24 Feb 2021

thanks

Add a Comment

Login with GitHub to post a comment