? ?

Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
20 Feb 2021

Pull Request for Issue # .

Summary of Changes

Currently, the method getForm of backend ArticleModel has code which handle form fields adjustment form both frontend and backend (thus in some places, it has to use $app->isClient to check to see if it is dealing with frontend or backend submit article, it even has to use application input to get article id..), so it is quite messy.

I re-arrange the code of that model. Instead of put everything into backend ArticleModel model, I move the code (which is related to frontend submit article only) to frontend FormModel to make it more clean and easier to maintain.

I also made some small adjustment:

Testing Instructions

  1. Apply patch
  2. Create/edit article from backend, make sure it is working as expected
  3. Create a menu item to link to Create Article menu option of com_content, submit an article, make sure it works.
avatar joomdonation joomdonation - open - 20 Feb 2021
avatar joomdonation joomdonation - change - 20 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Feb 2021
Category Administration com_content Front End
avatar infograf768
infograf768 - comment - 20 Feb 2021

Would that have an impact on #32462 ?

avatar joomdonation
joomdonation - comment - 20 Feb 2021

I would say no. In this PR, I just try to improve the code to make it more clean and easier to maintainer. However, there might be merge conflict.

avatar infograf768
infograf768 - comment - 20 Feb 2021

I hate merge conflicts... ;)

avatar joomdonation
joomdonation - comment - 20 Feb 2021

Allow me to improve the existing bad code first :).

avatar infograf768
infograf768 - comment - 20 Feb 2021

I checked: no merge conflicts, at least if your patch is merged first.

avatar Razzo1987
Razzo1987 - comment - 20 Feb 2021

With the nightly of 20 feb:
Notice: Undefined index: catid in /var/www/vhosts/jugmi.it/subdomains/j4/httpdocs/administrator/components/com_content/src/Model/ArticleModel.php on line 502

avatar joomdonation joomdonation - change - 20 Feb 2021
Labels Added: ?
avatar joomdonation
joomdonation - comment - 20 Feb 2021

Sorry @Razzo1987, there was a small typo in the code. I fixed it. Could you please help testing it again?

avatar Razzo1987 Razzo1987 - test_item - 20 Feb 2021 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 20 Feb 2021

I have tested this item successfully on 3fa58a5

Tested from backend and frontend with success


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32466.

avatar adj9 adj9 - test_item - 20 Feb 2021 - Tested successfully
avatar adj9
adj9 - comment - 20 Feb 2021

I have tested this item successfully on 3fa58a5

done


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32466.

avatar infograf768 infograf768 - change - 20 Feb 2021
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 20 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32466.

avatar infograf768 infograf768 - change - 20 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-20 17:42:08
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 20 Feb 2021
avatar infograf768 infograf768 - merge - 20 Feb 2021
avatar infograf768
infograf768 - comment - 20 Feb 2021

Tks.

Add a Comment

Login with GitHub to post a comment