User tests: Successful: 2 Razzo1987, adj9 Unsuccessful: 0
Pull Request for Issue # .
Currently, the method getForm of backend ArticleModel has code which handle form fields adjustment form both frontend and backend (thus in some places, it has to use $app->isClient to check to see if it is dealing with frontend or backend submit article, it even has to use application input to get article id..), so it is quite messy.
I re-arrange the code of that model. Instead of put everything into backend ArticleModel model, I move the code (which is related to frontend submit article only) to frontend FormModel to make it more clean and easier to maintain.
I also made some small adjustment:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_content Front End |
I would say no. In this PR, I just try to improve the code to make it more clean and easier to maintainer. However, there might be merge conflict.
I hate merge conflicts... ;)
Allow me to improve the existing bad code first :).
I checked: no merge conflicts, at least if your patch is merged first.
With the nightly of 20 feb:
Notice: Undefined index: catid in /var/www/vhosts/jugmi.it/subdomains/j4/httpdocs/administrator/components/com_content/src/Model/ArticleModel.php on line 502
Labels |
Added:
?
|
Sorry @Razzo1987, there was a small typo in the code. I fixed it. Could you please help testing it again?
I have tested this item
Tested from backend and frontend with success
I have tested this item
done
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-20 17:42:08 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
|
Tks.
Would that have an impact on #32462 ?