[#32459] - [4.0] Media manager compiled using rollup
- Fixed in Code Base
- 20 Feb 2021
- Medium
- Build: 4.0-dev
- # 32459
- Diff
- dgrammatiko:4.0-dev_com_media_rollup
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The main course here is the remove of webpack and compiling Media Manager with Rollup, but there are couple more:
- drop the dependency
FileSaver, we can do that in few lines:
- drop the
pathdependency (the reason is that it is commonJS and ruins the whole package) for own implementation (based on the actual code of NODEJS) - Moved the scss files in the build/media_source/com_media where is the appropriate place
- drop webpack with all the related dependencies
- Move the javascript tests to it's own package.json
- Move the
selenium-standalonedependency directly to done.yml
Testing Instructions
On a clean locally git cloned repo run npm install (or npm ci)
Check that the media manager has no bugs (create a folder, delete it, rename a folder, upload a file, rename a file, delete a file, download a file, edit a file)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests JavaScript Administration com_media NPM Change Repository |
I thought we weren't supporting ie?
Well, the build tools still produce IE compatible scripts, but there is a discussion about this #32148 In short I'm just fixing things without imposing decisions, if the PT decides to drop IE scripts it will be a modification of few lines...
@richard67 can you accept the Drone.yml changes in the Drone GUI?
@dgrammatiko You mean if I can re-sign that with a new checksum? Theoretically (privileges) I think yes, practically (experience) not yet. Maybe @HLeithner can help faster than I could?
| Labels |
Added:
NPM Resource Changed
?
?
|
||
I have tested this item
Media manager works as expected.
Created folder
Deleted folder
Renamed folder and files
Uploaded a file
Deleted files
Edited multiple files
Downloaded files
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32459.
@dgrammatiko Can't help you with signing the .drone.yml file, sorry.
@dgrammatiko Ahh wait, I did not read right .. you wrote drone GUI. Am checking now and see I have an "approve" buttons, so seems I can ;-)
Hmm, no, doesn't work for me.
| Labels |
Added:
?
Removed: ? |
||
@dgrammatiko My "Hmm, no, doesn't work for me." was referring to that drone signature thing, not to testing your PR.
I have tested this item
Testing is still good after changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32459.
@HLeithner could you unlock the drone here? Thanks
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
Can we leave the tests in the main package.json please. After our previous experience I think it's a bad thing to have this separated. I understand it makes most people's build times faster - but I'm sure it's bad from an overall maintenance perspective
| Labels |
Added:
?
Removed: ? |
||
| Category | Unit Tests JavaScript Administration com_media NPM Change Repository | ⇒ | JavaScript Administration com_media NPM Change Repository |
Tests are passing here on media manager so I'm happy with this
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-20 21:30:46 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Removed:
?
|
||
Thanks!
well, Media manager works "very clear" in IE
errors I posted in another PR, they all the same on every page,
but I did not seen errors related to MediaManager scripts
I tried to clear cache, a couple times, all the same,
but guess it not much important
if you like to play with it, you can use this https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/
as I made
I thought we weren't supporting ie?