? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
12 Feb 2021

The itemprop for the intro image that is NOT also a link is obviously incorrect.

https://schema.org/docs/search_results.html?q=thumbnail

Code review should be enough

(easier to create a PR than to create an override)

avatar brianteeman brianteeman - open - 12 Feb 2021
avatar brianteeman brianteeman - change - 12 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2021
Category Layout
avatar richard67 richard67 - test_item - 12 Feb 2021 - Tested successfully
avatar richard67
richard67 - comment - 12 Feb 2021

I have tested this item successfully on 49f6abd

Confirmed. According to the specs, the value of an element with itemprop thumbnailUrl is expected to be of type URL, and the value of an element with itemprop thumbnail is expected to be of type ImageObject.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32401.

avatar ceford ceford - test_item - 13 Feb 2021 - Tested successfully
avatar ceford
ceford - comment - 13 Feb 2021

I have tested this item successfully on 49f6abd

Applied patch and tested in real intro image. And followed link to better understand why itemprop should be there at all - mmm. Otherwise, all good.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32401.

avatar richard67 richard67 - change - 13 Feb 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 13 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32401.

avatar wilsonge wilsonge - change - 14 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-14 00:07:32
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 14 Feb 2021
avatar wilsonge wilsonge - merge - 14 Feb 2021
avatar wilsonge
wilsonge - comment - 14 Feb 2021

Thanks!

avatar brianteeman
brianteeman - comment - 14 Feb 2021

Thanks

Add a Comment

Login with GitHub to post a comment