? Pending

User tests: Successful: Unsuccessful:

avatar oantby
oantby
12 Feb 2021

Pull Request for Issue #32399.

Summary of Changes

Switch from searching by search_string, which is described as not required for bind-as-user, to building a filter based on the ldap_uid attribute laid out in settings.

Testing Instructions

  1. Enable LDAP plugin
  2. Set to bind directly as the user, and fill out required configuration, leaving search_string blank.
  3. set display_errors to On
  4. Go to administrative login
  5. Attempt to log in as a user who is valid in LDAP, but is not authorized to access Joomla!

Actual result BEFORE applying this Pull Request

Along with the authentication failure message, a php error message is displayed indicating an invalid LDAP filter.

Expected result AFTER applying this Pull Request

Only the intended authentication failure message is displayed.

Documentation Changes Required

None, to my knowledge.

avatar oantby oantby - open - 12 Feb 2021
avatar oantby oantby - change - 12 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2021
Category Front End Plugins
avatar oantby oantby - change - 12 Feb 2021
Labels Added: ?
avatar zero-24
zero-24 - comment - 12 Jun 2022

i will not merge this PR here into 3.10. i see where you are comming from but in oder to keep b/c with the current implementation i will keep it as it is. please sync the setting of the search string with the ldap_uid setting for now that should result into the same behavior.

thanks :-)

avatar zero-24 zero-24 - change - 12 Jun 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-06-12 19:07:58
Closed_By zero-24
Labels Added: ?
Removed: ?
avatar zero-24 zero-24 - close - 12 Jun 2022

Add a Comment

Login with GitHub to post a comment