@test

I can reproduce the problem. But the patch does not apply to current Joomla 2.5.25-dev.

Please can you update the PR?

@wilsonge Patch is against staging branch. No wonder it doesn't apply to a Joomla 2.5

I still have to learn some joomla structure on GitHub...
Only 17 Open J2.5 on the tracker. This may be one less

Great to learn some more everyday
http://docs.joomla.org/Git_for_Coders
Updating Georges PR for 2.5.x branch

Thankyou! This issue should still exist on 3.x though judging by the disgusting code :/ Can you also test that and this fix there please? As well as your PR for 2.5

There we go, first PR:
#4048

All right, but it seems that the issue in the tracker was renamed for 2.5 (let's blame Brian :-# )
Do we need another tracker item?
In the meantime, I am switching to latest XAMPP (was on 1.7.3 for J2.5...)

done
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=34023&start=0

@test
Successful, thanks George!
Need one more test

Please remane this to the new tracker item 8)
[#34023] Fix admin activation from email

Fixed :) thanks for the test and creating the new tracker! I'll test yours tomorrow when I have some time :)

My pleasure! Please change the tacker link in the top description as well ;-)

Could you fix the redundant variable?

$uParams = JComponentHelper::getParams('com_users');

-       // If the user is logged in, return them back to the homepage.
-       if ($user->get('id'))
+       // Check for admin activation. Don't allow non-super-admin to delete a super admin
+       $userParams = JComponentHelper::getParams('com_users');
+
+       if ($userParams->get('useractivation') != 2 && $user->get('id'))

we already have $uParams

I'm not sure if it is the right way to do it, so apologises if not.
I updated the PR to save George some time ;-)
variable name now updated, thanks Jean-Marie
See #4104

Thanks @rvbgnu. The correct way always includes respecting author of the first patch. Personally I try to send a PR against the user branch as it avoids duplicate issues/PRs and the original contributor can review if your patch is correct.

I merged this manually adding the fix for he duplicated variable and some codestyle fixes.

Thanks everybody!

All right, thank you @phproberto, always great to learn with this community ;-) I did not know that I could send a PR directly to user branch. Sorry George (from a GitHub newbie)

Thanks for the merge!

Don't worry about it! Thanks for sorting it. I'm up to my neck in new MVC so just not got any time at the moment!

Working as expected
#4376 (comment)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3239.