Joomla! Issue Tracker | Joomla! CMS #3238 - [#33423] Fixing onContentPrepareForm for multilang sites

Closed
9 Aug 2014
Medium
Build: staging
# 3238
Diff
chivitli:patch-5
Foreign ID 33423

Success

Success The Travis CI build passed Details

User tests: Successful: Unsuccessful:

chivitli
5 Mar 2014

When LanguageFilter plugin is enabled, the data object containing the form data (specified at http://docs.joomla.org/Plugin/Events/Content#onContentPrepareForm) gets converted to an array containing the data for some components, which results in inability to manipulate it as it isn't passed by reference.

This PR removes conversion to array and restores passing the data as an object, which seems to be the correct way.

To test, just make sure that multilingual assotiations/content still works fine when you are editing Content/Categories/Contacts/Newsfeeds

Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33423&start=0

chivitli - open - 5 Mar 2014

wilsonge - comment - 5 Apr 2014

Now do you actually mean language filter or language code? Because language filter doesn't even seem to have an onContentPrepareForm event and language code doesn't ever touch the data attribute. I can see there's some inconsistency - but not quite clear how it makes a difference in either of these plugins

chivitli - comment - 5 Apr 2014

@wilsonge

No, I really mean language filter. The problem is in this (snipet from article model in com_content, I added comments inline):

// check whether language filter is enabled
$assoc = JLanguageAssociations::isEnabled();
if ($assoc)
{
    $languages = JLanguageHelper::getLanguages('lang_code');
    // this conversion wouldn't happen is $assoc was false, meaning if language filter wasn't enabled
    // force to array (perhaps move to $this->loadFormData())
    $data = (array) $data;

chivitli - change - 5 Apr 2014

Title

…

Fixing onContentPrepareForm for multilang sites

[#33423] Fixing onContentPrepareForm for multilang sites