NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
10 Feb 2021

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@wilsonge

avatar dgrammatiko dgrammatiko - open - 10 Feb 2021
avatar dgrammatiko dgrammatiko - change - 10 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2021
Category NPM Change
avatar dgrammatiko dgrammatiko - change - 10 Feb 2021
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2021
Category NPM Change Administration com_installer Layout Libraries NPM Change
avatar dgrammatiko dgrammatiko - change - 10 Feb 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 10 Feb 2021
avatar richard67
richard67 - comment - 10 Feb 2021

Boottrap? It explains a lot if it really is a trap ;-)

avatar dgrammatiko
dgrammatiko - comment - 10 Feb 2021
giphy.mp4
avatar wilsonge wilsonge - change - 10 Feb 2021
Title
[4.0] update Boottrap to beta 2
[4.0] update Bootstrap to beta 2
avatar wilsonge wilsonge - edited - 10 Feb 2021
avatar wilsonge
wilsonge - comment - 10 Feb 2021

What's the popover change about. Obviously largely looks fine

avatar dgrammatiko
dgrammatiko - comment - 10 Feb 2021

What's the popover change about. Obviously largely looks fine

  • the $opt['offset'] = isset($options['offset']) ? $options['offset'] : [0, 0]; was initially removed from popovers as it was producing an error

  • The trigger is back to hover focus for all the elements that are supposed to present the popover on hover

  • There is a weird behaviour on the lists (articles, etc basically jGrid) and I think it's down to multiselect.js but that will need another PR Fixed, with proper delay values

avatar brianteeman
brianteeman - comment - 10 Feb 2021

multiselect is broken anyway

avatar dgrammatiko
dgrammatiko - comment - 10 Feb 2021

multiselect is broken anyway

might be but at this point the click events are mixed and the popovers are losing the proper target (at least this is my theory atm)

f98ec4c 10 Feb 2021 avatar dgrammatiko CS
avatar Magnytu2
Magnytu2 - comment - 11 Feb 2021

Hello how to try this? I don't see a .zip file and cannot install it in the Joomla patch tester? Is it available in the night version of Joomla 4?

avatar infograf768
infograf768 - comment - 11 Feb 2021

@dgrammatiko
Please update your branch as drone is blocked

avatar infograf768
infograf768 - comment - 11 Feb 2021

Grr, drone still dead

avatar rdeutz rdeutz - change - 11 Feb 2021
The description was changed
avatar rdeutz rdeutz - edited - 11 Feb 2021
avatar rdeutz
rdeutz - comment - 11 Feb 2021

the special char in the description was the problem that drone didn't run

avatar richard67
richard67 - comment - 11 Feb 2021

@dgrammatiko If you have emojis in title or description of a PR, it can happen that ci jobs (here drone) don't work. In case of this PR it was the bell for calling George ;-)

avatar richard67
richard67 - comment - 11 Feb 2021

Hello how to try this? I don't see a .zip file and cannot install it in the Joomla patch tester? Is it available in the night version of Joomla 4?

@Magnytu2 In the nightly builds PRs which haven't been merged yet will never be included. But the zip files for this PR should be available now for testing.

avatar Magnytu2
Magnytu2 - comment - 11 Feb 2021

Yes I just tested and it works. The wok flow bubble has disappeared. Great, thank you very much to all the developer team.

avatar wilsonge wilsonge - change - 11 Feb 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-11 12:26:37
Closed_By wilsonge
avatar wilsonge wilsonge - close - 11 Feb 2021
avatar wilsonge wilsonge - merge - 11 Feb 2021
avatar wilsonge
wilsonge - comment - 11 Feb 2021

Ok let’s get this in for wider testing. Thanks!

avatar Magnytu2
Magnytu2 - comment - 11 Feb 2021

@wilsonge @richard67 and ... Wouldn't it be time to switch to joomla! 4 RC. I think a lot of people would be more excited to test and escalate the issues. For extension developers too.

avatar wilsonge
wilsonge - comment - 11 Feb 2021

Basically what @brianteeman said @Magnytu2 - we need help fixing the release blockers before I feel comfortable releasing an RC - but yes I'd like to release one as soon as we work through the list of blockers

avatar dgrammatiko
dgrammatiko - comment - 23 Mar 2021
avatar peteruoi
peteruoi - comment - 23 Mar 2021

Respect sir! :)

Add a Comment

Login with GitHub to post a comment