Feeling Lucky
NPM Resource Changed
?
?
[#32377] - [4.0] Updated switcher.php layout and its corresponding scss files
- Fixed in Code Base
- 11 Feb 2021
- Medium
- Build: 4.0-dev
- # 32377
- Diff
- thednp:patch-5
User tests: Successful: Unsuccessful:
Summary of Changes
Since the <legend> added to the switch field type is set to use visually-hidden class, with the self explanatory function, all the additional styling is redundant, hence we clean it up.
Pull Request for Issue #32367 (comment) .
Testing Instructions
Simplest way to test:
- go to
System-Site Template Styles-Cassiopeia - go to
Advancedtab and inspect the<legend>element of the setting calledLayout - the
.switcher__legendclass should have no style before merging the #32367 into the 4.0 branch
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No visual or functional change is expected since the target element uses the .visually-hidden class
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration Templates (admin) NPM Change | ⇒ | Administration Templates (admin) NPM Change Layout |
thednp
- comment
- 10 Feb 2021
@brianteeman roger, also updated. Thanks man.
| Title |
|
||||||
| Category | Administration Templates (admin) NPM Change Layout | ⇒ | Administration Templates (admin) NPM Change Repository Layout |
| Title |
|
||||||
Quy
- comment
- 10 Feb 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32377.
infograf768
- comment
- 11 Feb 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32377.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 11 Feb 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32377.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-11 07:21:45 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
infograf768
- comment
- 11 Feb 2021
Tks
If you are removing the classes from the template css then you should also remove the reference to them in the php markup.
For reference the class was not invented for fun as it did serve a purpose when the code was originally committed by me at #24463.
The code was made useless by changes in #27684 which was when it should have been removed