User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Refactors the quicklinks CSS, removing redundant rules and general cleanup. Fixes some minor spacing inconsistencies.
Apply PR and run npm run build:css
to compile the SCSS. Check quicklinks are displayed as before.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change Layout |
Labels |
Added:
NPM Resource Changed
?
|
@ChristineWk @ciar4n Edit the module, For many site icons it is possible to choose show / hide / show item with count.
It's one of the hidden secrets of J4 ....
I have tested this item
Names and numbers are now black, what changes the look of the buttons. It does not affect function.
@ciar4n The scss linter complains: https://ci.joomla.org/joomla/joomla-cms/39938/1/20
administrator/templates/atum/scss/blocks/_quickicons.scss
21:40 ✖ Unexpected whitespace at end of line no-eol-whitespace
23:10 ✖ Unexpected whitespace at end of line no-eol-whitespace
27:7 ✖ Expected "align-items" to come before "justify-content" order/properties-order
30:7 ✖ Expected "text-align" to come before "background-color" order/properties-order
31:7 ✖ Expected "color" to come before "text-align" order/properties-order
34:26 ✖ Unexpected whitespace at end of line no-eol-whitespace
52:9 ✖ Expected "color" to come before "text-decoration" order/properties-order
58:8 ✖ Unexpected whitespace at end of line no-eol-whitespace
63:8 ✖ Unexpected whitespace at end of line no-eol-whitespace
72:10 ✖ Unexpected whitespace at end of line no-eol-whitespace
78:8 ✖ Unexpected whitespace at end of line no-eol-whitespace
84:8 ✖ Unexpected whitespace at end of line no-eol-whitespace
92:8 ✖ Unexpected whitespace at end of line no-eol-whitespace
107:7 ✖ Expected "font-size" to come before "background-color" order/properties-order
112:6 ✖ Unexpected whitespace at end of line no-eol-whitespace
119:7 ✖ Expected indentation of 8 spaces indentation
120:7 ✖ Expected indentation of 8 spaces indentation
121:7 ✖ Expected indentation of 8 spaces indentation
122:9 ✖ Expected indentation of 10 spaces indentation
124:11 ✖ Expected nesting depth to be no more than 4 max-nesting-depth
Thank you
Names and numbers are now black, what changes the look of the buttons. It does not affect function.
@chmst Names and number should be now displayed as before
The scss linter complains: https://ci.joomla.org/joomla/joomla-cms/39938/1/20
@richard67 Should be good now
I have tested this item
@richard67 Are you referring to width?
After npm run build:css it sould be ok. My latest test shows icons after PR the same as before PR, same size, same colour.
@ciar4n Yes, width.
@chmst Sure I did run npm.
What I saw is that at certain widths icons are same as before, but if you make width smaller or larger then, then you will see a difference. The changes from 3 to 2 to 1 quickicon in a row happens at different widths than before, and from my point of view too early when reducing from large to smaller width.
Not sure if I explain it well, am not a CSS guy.
@richard67 I undertstand, I have reduced the min-width of each item to 160px (previously 180px). This should be closer to what you have in mind?
I have tested this item
I have tested this item
It is ok for me on my rather small monitor every width looks good.
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-09 08:46:03 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
|
Tks
The size had a meaning. If numbers are added, the icon must be smaller.
Before Patch
After patch