NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
6 Feb 2021

Pull Request for Issue # .

Summary of Changes

Refactors the quicklinks CSS, removing redundant rules and general cleanup. Fixes some minor spacing inconsistencies.

Testing Instructions

Apply PR and run npm run build:css to compile the SCSS. Check quicklinks are displayed as before.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

avatar ciar4n ciar4n - open - 6 Feb 2021
avatar ciar4n ciar4n - change - 6 Feb 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2021
Category Administration Templates (admin) NPM Change Layout
avatar ciar4n ciar4n - change - 6 Feb 2021
Labels Added: NPM Resource Changed ?
avatar chmst
chmst - comment - 6 Feb 2021

The size had a meaning. If numbers are added, the icon must be smaller.
Before Patch

grafik

After patch

quickicon

avatar ciar4n
ciar4n - comment - 6 Feb 2021

Thanks @chmst .. how are the numbers added?

avatar ciar4n
ciar4n - comment - 6 Feb 2021

@chmst should be ok now

avatar ChristineWk
ChristineWk - comment - 6 Feb 2021

Thanks @chmst .. how are the numbers added?

https://issues.joomla.org/tracker/joomla-cms/32223

avatar ciar4n ciar4n - change - 6 Feb 2021
The description was changed
avatar ciar4n ciar4n - edited - 6 Feb 2021
avatar ciar4n ciar4n - change - 7 Feb 2021
The description was changed
avatar ciar4n ciar4n - edited - 7 Feb 2021
avatar chmst
chmst - comment - 7 Feb 2021

@ChristineWk @ciar4n Edit the module, For many site icons it is possible to choose show / hide / show item with count.

It's one of the hidden secrets of J4 ....

grafik

avatar chmst chmst - test_item - 7 Feb 2021 - Tested successfully
avatar chmst
chmst - comment - 7 Feb 2021

I have tested this item successfully on 966bf6d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32336.

avatar chmst
chmst - comment - 7 Feb 2021

Names and numbers are now black, what changes the look of the buttons. It does not affect function.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32336.

avatar richard67
richard67 - comment - 7 Feb 2021

@ciar4n The scss linter complains: https://ci.joomla.org/joomla/joomla-cms/39938/1/20

administrator/templates/atum/scss/blocks/_quickicons.scss
  21:40  ✖  Unexpected whitespace at end of line                      no-eol-whitespace     
  23:10  ✖  Unexpected whitespace at end of line                      no-eol-whitespace     
  27:7   ✖  Expected "align-items" to come before "justify-content"   order/properties-order
  30:7   ✖  Expected "text-align" to come before "background-color"   order/properties-order
  31:7   ✖  Expected "color" to come before "text-align"              order/properties-order
  34:26  ✖  Unexpected whitespace at end of line                      no-eol-whitespace     
  52:9   ✖  Expected "color" to come before "text-decoration"         order/properties-order
  58:8   ✖  Unexpected whitespace at end of line                      no-eol-whitespace     
  63:8   ✖  Unexpected whitespace at end of line                      no-eol-whitespace     
  72:10  ✖  Unexpected whitespace at end of line                      no-eol-whitespace     
  78:8   ✖  Unexpected whitespace at end of line                      no-eol-whitespace     
  84:8   ✖  Unexpected whitespace at end of line                      no-eol-whitespace     
  92:8   ✖  Unexpected whitespace at end of line                      no-eol-whitespace     
 107:7   ✖  Expected "font-size" to come before "background-color"    order/properties-order
 112:6   ✖  Unexpected whitespace at end of line                      no-eol-whitespace     
 119:7   ✖  Expected indentation of 8 spaces                          indentation           
 120:7   ✖  Expected indentation of 8 spaces                          indentation           
 121:7   ✖  Expected indentation of 8 spaces                          indentation           
 122:9   ✖  Expected indentation of 10 spaces                         indentation           
 124:11  ✖  Expected nesting depth to be no more than 4               max-nesting-depth
dc0f917 8 Feb 2021 avatar ciar4n cs
fbba7f8 8 Feb 2021 avatar ciar4n cs
avatar ciar4n
ciar4n - comment - 8 Feb 2021

Thank you

Names and numbers are now black, what changes the look of the buttons. It does not affect function.

@chmst Names and number should be now displayed as before

The scss linter complains: https://ci.joomla.org/joomla/joomla-cms/39938/1/20

@richard67 Should be good now

avatar chmst chmst - test_item - 8 Feb 2021 - Tested successfully
avatar chmst
chmst - comment - 8 Feb 2021

I have tested this item successfully on fbba7f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32336.

avatar richard67
richard67 - comment - 8 Feb 2021

As @chmst 's screenshot above shows, and I have the same result here, the quicklinks are much bigger at certain screen sizes as they are without the PR. Is that really intended? It's a matter of taste maybe, but in my opinion it wastes space.

avatar ciar4n
ciar4n - comment - 8 Feb 2021

@richard67 Are you referring to width?

avatar chmst
chmst - comment - 8 Feb 2021

After npm run build:css it sould be ok. My latest test shows icons after PR the same as before PR, same size, same colour.

avatar richard67
richard67 - comment - 8 Feb 2021

@ciar4n Yes, width.

@chmst Sure I did run npm.

What I saw is that at certain widths icons are same as before, but if you make width smaller or larger then, then you will see a difference. The changes from 3 to 2 to 1 quickicon in a row happens at different widths than before, and from my point of view too early when reducing from large to smaller width.

Not sure if I explain it well, am not a CSS guy.

avatar ciar4n
ciar4n - comment - 8 Feb 2021

@richard67 I undertstand, I have reduced the min-width of each item to 160px (previously 180px). This should be closer to what you have in mind?

avatar richard67
richard67 - comment - 8 Feb 2021

@ciar4n Yes, closer to sizes before and still fixing spacing inconsistencies as described.

avatar richard67 richard67 - test_item - 8 Feb 2021 - Tested successfully
avatar richard67
richard67 - comment - 8 Feb 2021

I have tested this item successfully on 40fb068


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32336.

avatar richard67
richard67 - comment - 8 Feb 2021

@chmst Could you test again? And make sure you clear cache after npm, or force reload or switch off cache, because it definitely can't be 100% the same as before at all sizes. Thanks in advance.

avatar chmst chmst - test_item - 8 Feb 2021 - Tested successfully
avatar chmst
chmst - comment - 8 Feb 2021

I have tested this item successfully on 40fb068

It is ok for me on my rather small monitor every width looks good.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32336.

avatar richard67 richard67 - change - 8 Feb 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 8 Feb 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32336.

avatar infograf768 infograf768 - change - 9 Feb 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-09 08:46:03
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 9 Feb 2021
avatar infograf768 infograf768 - merge - 9 Feb 2021
avatar infograf768
infograf768 - comment - 9 Feb 2021

Tks

Add a Comment

Login with GitHub to post a comment