Feeling Lucky
NPM Resource Changed
?
?
[#32335] - [4.0] Fix pre tag display in blog/featured layouts.
- Fixed in Code Base
- 17 Feb 2021
- Medium
- Build: 4.0-dev
- # 32335
- Diff
- Harmageddon:fix_pre_tags_in_blog
User tests: Successful: Unsuccessful:
Pull Request for Issue #32296.
This is an alternative solution to #32322. You'll need NPM to test this PR!
Summary of Changes
Added an overflow:hidden so that blog item divs don't expand with <pre> tags inside their content.
Testing Instructions
- Create an article. In the content, add a HTML
<pre>tag with at least one very long line inside it. - Mark the article as featured and add it to a category.
- Look at the article in frontend in the following views:
- single article
- category blog
- featured blog
Actual result BEFORE applying this Pull Request
The pre tag destroys the blog layouts (but is correctly displayed in single article view).
Expected result AFTER applying this Pull Request
The pre tag gets a vertical scrollbar and is displayed inside the limits of the article.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
ChristineWk
- comment
- 13 Feb 2021
I have tested this item
Used Prebuilt Package
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32335.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
NPM Resource Changed
|
||
richard67
- comment
- 13 Feb 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32335.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-17 18:56:45 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 17 Feb 2021
Thanks!
I have tested this item✅ successfully on 1a40e91
The pre line does not obviously scroll and is only recognisable from the font difference - would it benefit from some additional style? I guess authors could apply their own class.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32335.