[#32299] - Fix Privacy Request Email Data Export Error
- Fixed in Code Base
- 15 Mar 2021
- Medium
- Build: staging
- # 32299
- Diff
- joomdonation:fix_email_data_export
User tests: Successful: Unsuccessful:
Pull Request for Issue #32272 .
Summary of Changes
The emailexport method of PrivacyControllerRequest controller check form token from GET ( see https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_privacy/controllers/request.php#L139 ), however, the form token is not passed in the URL and it causes the error below when the button is pressed:
The security token did not match. The request was aborted to prevent any security breach. Please try again
This simple PR just fixes that error.
Testing Instructions
- Code review.
- Real test: See comment #32299 (comment) below.
Actual result BEFORE applying this Pull Request
See issue #32272 : Error "The security token did not match. The request was aborted to prevent any security breach. Please try again"
Expected result AFTER applying this Pull Request
No error will be shown. The data is exported and emailed.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
@richard67 Yes. However, I don't have experience with Privacy Request, so I might give a wrong testing instructions:
- Create a menu item to link to Create Request menu item type of Privacy component
- Go to frontend of your site, access to that menu item, enter your email and submit a Export request. You should receive an email, please follow instructions in the email to confirm the request
- Now, go to backend of your site, access to Users -> Privacy, then Requests, you will see list of requests. Click on a confirmed request
- On the screen, you will see the request details. Press on Email Data Export button in the toolbar:
- Before patch, you will receive the error "The security token did not match. The request was aborted to prevent any security breach. Please try again"
- After patch, no error will be shown. The data is exported and emailed.
Now, go to frontend of your site, access to Users -> Privacy, then Requests, you will see list of requests. Click on a confirmed request
@joomdonation Shouldn't that be "backend"? Beside that it looks ok to me, so after correction copy it to the testing instructions in the description, please.
And we have PHP a code style error: https://ci.joomla.org/joomla/joomla-cms/39856/1/3 . You know how to fix it? Let me know if not.
@richard67, yes, that should be backend. I corrected it. Could you please help with the Line exceeds CS? I don't know how to fix that one.
@joomdonation You can just commit the above suggested change with the button on GitHub.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32299.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32299.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32299.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-15 10:12:04 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@joomdonation Could it be also tested with a real test, i.e. reproducing issue #32272 ? I would prefer that to a code review only.