Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#32271] - [4.0] Fix associations modal

? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
3 Feb 2021

Summary of Changes

Assocations modal current doesn't evaluate the forced language when trying to select a counterpart language for an (e.g. article).

@dgrammatiko I'm well aware this seems sub-optimal (security etc) - but definitely fixes the issue in chrome (and is the original code we had in bootstrap-init.js from #21176). Where does this code come from in J3 btw? I'm so confused :D

Testing Instructions

Load an article in com_assocations and try and select a counterpart language. Before patch no articles show to select. After patch they do.

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 3 Feb 2021
avatar wilsonge wilsonge - change - 3 Feb 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2021
Category ⇒ JavaScript Repository NPM Change
avatar wilsonge wilsonge - change - 3 Feb 2021
Title
…
Fix associations modal
[4.0] Fix associations modal
avatar wilsonge wilsonge - edited - 3 Feb 2021
avatar dgrammatiko
dgrammatiko - comment - 3 Feb 2021

Where does this code come from in J3 btw

tbh I have no clue, I think all this code is related to the modal field, so fixing this somehow we need to fix how those modals are created/initialised/etc. I think a simple solution would be to use a <template> and attach the iframe/buttons needed per instance. For now this will do

Edit el = (new Function(idFieldArr[0]))(); should do the same

avatar infograf768
infograf768 - comment - 3 Feb 2021

This solves not only the list display in com_associations popu-up when using the Target button, but also the Edit Article modal displaying a new article to create instead of the article to edit.

avatar infograf768 infograf768 - test_item - 3 Feb 2021 - Tested successfully
avatar infograf768
infograf768 - comment - 3 Feb 2021

I have tested this item ✅ successfully on 685c6af

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32271.

avatar infograf768
infograf768 - comment - 3 Feb 2021

Tests instructions to be modified, as well as title of PR ;)

Before patch

editarticlemodal

After patch
Screen Shot 2021-02-03 at 11 17 21

com_associations

before patch

associations target

after patch

Screen Shot 2021-02-03 at 11 19 09

avatar FrederikGostn FrederikGostn - test_item - 3 Feb 2021 - Tested successfully
avatar FrederikGostn
FrederikGostn - comment - 3 Feb 2021

I have tested this item ✅ successfully on 685c6af

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32271.

avatar wilsonge
wilsonge - comment - 3 Feb 2021

Edit el = (new Function(idFieldArr[0]))(); should do the same

Unfortunately it doesn't. It doesn't find the element with document.getElementById so just spits out undefined - I tried that first

avatar dgrammatiko
dgrammatiko - comment - 3 Feb 2021

merge this and I will try to fix the modal field at some point

avatar infograf768
infograf768 - comment - 3 Feb 2021

Note

When editing article in popup and using the Close or save and close button, I get here a js error which has no apparent impact on the results

Uncaught TypeError: dropDownBtn is null
    <anonymous> http://localhost:8888/newfolder/joomla40/media/com_workflow/js/admin-items-workflow-buttons.js?72877f5947223d2ad184590c607abc42:50
    EventListener.handleEvent* http://localhost:8888/newfolder/joomla40/media/com_workflow/js/admin-items-workflow-buttons.js?72877f5947223d2ad184590c607abc42:48
    <anonymous> http://localhost:8888/newfolder/joomla40/media/com_workflow/js/admin-items-workflow-buttons.js?72877f5947223d2ad184590c607abc42:130
admin-items-workflow-buttons.js:50:23

When save and close
I may get

 Uncaught Error: The component must be in a context to send: triggerEvent
<button title="Formats" aria-label="Formats" aria-haspopup="true" type="button" unselectable="on" tabindex="-1" class="tox-tbtn tox-tbtn--select tox-tbtn--bespoke" style="user-select: none;" aria-expanded="false"></button> is not in context.
   t http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/themes/silver/theme.min.js:9
   $o http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/themes/silver/theme.min.js:9
   qo http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/themes/silver/theme.min.js:9
   n http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/themes/silver/theme.min.js:9
   e http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/themes/silver/theme.min.js:9
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27512
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27617
   nodeChanged http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:24821
   nodeChanged http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:28427
   1 http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:21296
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27512
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27617
   addUndoLevel http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:17305
   addUndoLevel http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:17407
   addUndoLevel$1 http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:17630
   add http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:21316
   addNonTypingUndoLevel http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:21208
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27512
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27617
   save http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:28526
   render http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:26760
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27512
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27617
   formEventDelegate http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:26733
   executeHandlers http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:5146
   defaultNativeHandler http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:4949
   submitform http://localhost:8888/newfolder/joomla40/media/system/js/core.js?4f9ecdeceffffd46b53e938246561f54:410
   submitbutton http://localhost:8888/newfolder/joomla40/media/system/js/core.js?4f9ecdeceffffd46b53e938246561f54:446
   processModalEdit http://localhost:8888/newfolder/joomla40/media/system/js/fields/modal-fields.js?01305c3c4d24ff10a376dcf30f48636b:171
   onclick http://localhost:8888/newfolder/joomla40/administrator/index.php?option=com_menus&view=item&client_id=0&layout=edit&id=131:1
theme.min.js:9:28139
   t http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/themes/silver/theme.min.js:9
   $o http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/themes/silver/theme.min.js:9
   qo http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/themes/silver/theme.min.js:9
   n http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/themes/silver/theme.min.js:9
   e http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/themes/silver/theme.min.js:9
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27512
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27617
   nodeChanged http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:24821
   nodeChanged http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:28427
   1 http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:21296
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27512
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27617
   addUndoLevel http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:17305
   addUndoLevel http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:17407
   addUndoLevel$1 http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:17630
   add http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:21316
   addNonTypingUndoLevel http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:21208
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27512
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27617
   save http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:28526
   render http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:26760
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27512
   fire http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:27617
   formEventDelegate http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:26733
   executeHandlers http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:5146
   defaultNativeHandler http://localhost:8888/newfolder/joomla40/media/vendor/tinymce/tinymce.js?4f9ecdeceffffd46b53e938246561f54:4949
   submitform http://localhost:8888/newfolder/joomla40/media/system/js/core.js?4f9ecdeceffffd46b53e938246561f54:410
   submitbutton http://localhost:8888/newfolder/joomla40/media/system/js/core.js?4f9ecdeceffffd46b53e938246561f54:446
   processModalEdit http://localhost:8888/newfolder/joomla40/media/system/js/fields/modal-fields.js?01305c3c4d24ff10a376dcf30f48636b:171
   onclick http://localhost:8888/newfolder/joomla40/administrator/index.php?option=com_menus&view=item&client_id=0&layout=edit&id=131:1

and sometimes

Screen Shot 2021-02-03 at 11 27 52

and

NS_ERROR_UNEXPECTED: theme.min.js:9

avatar dgrammatiko
dgrammatiko - comment - 3 Feb 2021

@infograf768 open a new issue for this, it will need some testing/debugging

avatar infograf768
infograf768 - comment - 3 Feb 2021

Will do, once this is tested by second tester and merged.

avatar dgrammatiko
dgrammatiko - comment - 3 Feb 2021

It has already 2 tests

avatar infograf768
infograf768 - comment - 3 Feb 2021

@dgrammatiko
The second tester was already blocked under various aliases. Let's wait for another tester.

avatar dgrammatiko dgrammatiko - test_item - 3 Feb 2021 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 3 Feb 2021

I have tested this item ✅ successfully on 685c6af

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32271.

avatar infograf768 infograf768 - change - 3 Feb 2021
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 3 Feb 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32271.

avatar wilsonge wilsonge - change - 3 Feb 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-02-03 10:44:45
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 3 Feb 2021
avatar wilsonge wilsonge - merge - 3 Feb 2021
avatar infograf768
infograf768 - comment - 3 Feb 2021

@dgrammatiko

See #32278

Add a Comment

Login with GitHub to post a comment