?
avatar PhilETaylor
PhilETaylor
2 Feb 2021

Steps to reproduce the issue

Can we nuke this?

console.log('SkipTo loaded...');

No idea where the source is coming from but its compiled into media/vendor/skipto/js/skipto.js and skipto.min.js

We must be modifying the source somehow as there is Joomla name spacing in it.

Expected result

Nothing in console.log

Actual result

Screenshot 2021-02-02 at 22 24 02

unneeded debug information output

avatar PhilETaylor PhilETaylor - open - 2 Feb 2021
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Feb 2021
avatar PhilETaylor
PhilETaylor - comment - 2 Feb 2021

@dgrammatiko ? maybe?

avatar PhilETaylor PhilETaylor - change - 2 Feb 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 2 Feb 2021
avatar dgrammatiko
dgrammatiko - comment - 2 Feb 2021

We need to make a PR on their repo, again ?

avatar PhilETaylor
PhilETaylor - comment - 2 Feb 2021

oh does it have history then haha ? I saw the Joomla specific lines above the console.log so assumed you were modifying their code anyway and could easily nuke this ?

 // Initialize skipto menu button with onload event
  window.addEventListener('load', function() {
    SkipTo.init(window.SkipToConfig ||
                window.Wordpress ||
                ((typeof window.Joomla === 'object' && typeof window.Joomla.getOptions === 'function') ? window.Joomla.getOptions('skipto-settings', {}) : {})
                );
    console.log('SkipTo loaded...'); // jshint ignore:line
  });
avatar PhilETaylor
PhilETaylor - comment - 2 Feb 2021

It would be a shame to leave this one, just as we get rid of the jQuery.Migrate console.log that has been following Joomla console logs around for the last decade ;-)

avatar dgrammatiko
dgrammatiko - comment - 2 Feb 2021

Yeah man, I added those: paypal/skipto#69 ?
I'll try to nuke it but you know it's their call

avatar PhilETaylor PhilETaylor - close - 2 Feb 2021
avatar PhilETaylor
PhilETaylor - comment - 2 Feb 2021

Ta - will nuke this issue for now then as can't really do anything here.

avatar PhilETaylor PhilETaylor - change - 2 Feb 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-02-02 22:33:15
Closed_By PhilETaylor
avatar dgrammatiko
dgrammatiko - comment - 2 Feb 2021

For reference paypal/skipto#79

avatar PhilETaylor
PhilETaylor - comment - 2 Feb 2021

Thanks.

avatar dgrammatiko
dgrammatiko - comment - 3 Feb 2021

@PhilETaylor paypal/skipto#79 was merged so now we have to wait for their next release

avatar brianteeman
brianteeman - comment - 3 Feb 2021

I will push a new release shortly as there are some other bugs fixed upstream

avatar dgrammatiko
dgrammatiko - comment - 3 Feb 2021

@brianteeman npm says that last release was 19 days ago

Add a Comment

Login with GitHub to post a comment