Feeling Lucky
?
[#32230] - [4.0] Fixing issues from Psalm quality checks
- Fixed in Code Base
- 15 Feb 2021
- Medium
- Build: 4.0-dev
- # 32230
- Diff
- Hackwar:j4psalm
User tests: Successful: Unsuccessful:
This is another batch of fixes to docblocks and method calls from the Psalm quality tool. This can not be tested, but needs to be reviewed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Hackwar
- comment
- 3 Feb 2021
Which is why I'm starting small and doing little steps. Not claiming to fix every problem everywhere, but when I run into them, I can fix them. Every improvement helps when later working with an IDE.
PhilETaylor
- comment
- 3 Feb 2021
Totally agree. phpStorm has a nightmare at the moment :-(
wilsonge
- comment
- 4 Feb 2021
One fix required and this is good to merge
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-15 12:32:24 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 15 Feb 2021
Thanks!
Careful... you will get dragged down a huge rabbit hole updating the docblocks and the types of each param... literally thousands of them are wrong. I looked to fix them but was overwhelmed! Making joomla type safe is going to be a nightmare in the future.