[#32229] - [4.0] Subform instead of SubForm
- Fixed in Code Base
- 1 Feb 2021
- Medium
- Build: 4.0-dev
- # 32229
- Diff
- ReLater:patch-1
User tests: Successful: Unsuccessful:
Summary of Changes
- See changed code. Typo corrected.
Testing Instructions
-
#32217 must be fixed/merged first.
-
Go to
administrator/index.php?option=com_config&view=component&component=com_users -
Tabulator
Email Domain Options -
Add a subform row, fill it
-
Click on
Save
Actual result BEFORE applying this Pull Request
- Error
Call to a member function test() on bool,JROOT/libraries/src/Form/FormField.php:1249 - This happens in all extensions with a subform via JForm.
Expected result AFTER applying this Pull Request
- Saving without error
- Subform field correctly saved and displayed with newly created row
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-01 11:27:58 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
This should probably be documented on the B/C breaks page.
Thinking about it, I wonder if a better (or additional) solution would be to put a ucfirst() into the FormHelper::loadType() method.
This should probably be documented on the B/C breaks page.
Here is no b/c. It does not rename the class, just correcting the loading.
Or do you mean the FormHelper::loadRuleType in general?
FormHelper::loadRuleType('foobar') in J 3
vs
FormHelper::loadRuleType('Foobar') in J 4
I do not think it b/c. FormHelper::loadClass internally use ucfirst already.
What we have in this patch is CamelCase issue.
I have tested this item✅ successfully on 5fcb38d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32229.