[#32202] - [4.0] svg logo [a11y]
- Fixed in Code Base
- 4 Feb 2021
- Medium
- Build: 4.0-dev
- # 32202
- Diff
- brianteeman:svg_focus
User tests: Successful: Unsuccessful:
Due to some "bugs" in some screenreaders and browsers and how they handle svg it is recommended to set them to focusable=false and ensure they have the correct role.
Because of the way we handle svg logos in the template this has to be done in the js and not the svg file itself.
The only way to really test after applying the PR and npm i is to view the source. If successable the svg will have the role and focusable attributes as below
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
No I cannot replicate that
I ran npm ci and then checked template.js and template.min.js
template.js contains what I expect and works. template.min.js contains f.setAttribute("role","presentation"),f.setAttribute("focusable","false") and does not work in Firefox or Chrome on Mac. Both files have the same date/time consistent with the npm compilation. Also I have template.es6 versions. Does all that mean there is something amiss with my npm compilation? I don't see any javascript errors.
I have tested this item
I traced the problem I reported to the presence of template.min.js.gz dated to a few days ago. Deleting that file fixed the problem.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32202.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32202.
Question: do all svg need to be modified this way?
Example: the webauthn.svg
Ask the accessibility team
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32202.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-04 15:02:24 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
?
|
||
Thanks!
thanks
This is only working with Debug System = Yes in Global Configuration. Is that expected at this stage?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32202.