[#3220] - $app->registeredurlparams is not defined
- Closed
- 25 May 2014
- Medium
- Build: staging
- # 3220
- Diff
- Hackwar:patch-8
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Moving the rest of the function inside the if loop makes sure $app->registeredurlparams is only referred to if actually exists.
This was causing memory leak on 3.2.1 Joomla install over PHP 5.5, performance has increased after the fix.
This is a replacement for #2706 with a better fix, since there was no response from @FriendlyHacker in 2 months. Thank you for your work.
I know it's not really your submission but is there any easy way of replicating this Hannes? (obviously from a code perspective it's correct - but just to do the official testing crap)
I can confirm this fixes the issue, and has not broken anything else so far.
This is how you replicate it:
1 - Enable warnings to be written to PHP error log.
2 - Visit your site a few times
3 - Open error log
4 - Find PHP Warning: Creating default object from empty value in libraries/joomla/cache/cache.php on line 702
5 - Apply fix
6 - Watch Joomla performance double
For extra effect, clear your error log file. This warning message gets written every time someone visits and you might have a huge log file consuming all your server's RAM because of it.
Bakual
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-05-25 11:41:34 |
Tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33401&start=0