[#3219] - [#32441] Fix divison by 0 issue in debug plugin
- Closed
- 24 Mar 2014
- Medium
- Build: staging
- # 3219
- Diff
- Hackwar:patch-7
- Foreign ID 32441
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
If you send an empty DB query (thus strlen($query) = 0) you get a division by 0. With this little change, the string length is always at least 1. Since this is onyl to roughly guess if a query is good or bad, changing the result of this by +1 doesn't have a real impact. This will also mean, that these queries get a high value and show up as bad. And I think we can all agree that an empty query is simply a waste of perfectly good CPU cycles. ;-)
This is a replacement for PR #1539 by @elinw Thank you!
Tracker item is here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32441&start=0
Please mark your test in the tracker item.
infograf768
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-24 09:28:32 |
| Title |
|
||||||
| Title |
|
||||||
Bakual
-
Easy no brainer. Sounds good to go @Hackwar
Thanks!