User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Test various views in the backend and confirm nothing is broken
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_associations com_categories com_config com_fields com_installer com_media com_modules JavaScript Repository NPM Change Installation Layout |
Labels |
Added:
NPM Resource Changed
?
|
Some filename changes
Where?
Where?
It happens in the build steps, check build/build-modules-js/javascript/compile-w-c.es6.js
and build/build-modules-js/settings.json
So we probably need to add the old files to the list of files to be removed for those people updating
So we probably need to add the old files to the list of files to be removed for those people updating
Updating from J3 is not affected, between betas I have no clue how this is handled.
between betas is the same as 3.x to 3.x+1
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/script.php#L5016
between betas is the same as 3.x to 3.x+1
ok will add all the affected files there
Well, it does not need to rename everything, that not productive, and probably will lead to bugs.
It will work perfectly fine with existing names
I have tested this item
CodeMirror and None editors tested working now.
Well, then, with all this renaming it not acceptable at beta stage, to me. Sorry.
All was need is just disable transpiller and drop WC loader in core.js.
All was need is just disable transpiller and drop WC loader in core.js.
That's not what this PR is doing. It just aligns the idiomatic (different and odd) web components names to the rest of the scripts and also treats them as modules (totally fine, there's just a class in there). Why is it not acceptable?
PS I stand corrected if the target is ES6 to be the .min.js
this is a step backwards...
All was need is just disable transpiller and drop WC loader in core.js.
Wouldn't that be a second step to accomplish after this PR? I believe we discussed best course of action is a step by step approach instead of some monolithic PR. @dgrammatiko states as much here.
@chnnst would be more helpful if you tested the PR and log it here: https://issues.joomla.org
Don't get me wrong but likes are not really helpful here
Category | Administration com_associations com_categories com_config com_fields com_installer com_media com_modules JavaScript Repository NPM Change Installation Layout | ⇒ | JavaScript Repository NPM Change Libraries Front End Plugins |
Category | JavaScript Repository NPM Change Libraries Front End Plugins | ⇒ | Repository NPM Change Libraries Front End Plugins |
Thanks! that looks much better.
webcomponent prefix
There 2 reason:
webcomponent.blabla
. And any renaming will break it. (remember there a couple betas already out)file names
This for future updates.
It better to use "final file name" (without suffix) to avoid future confusion with renaming, because after we fully move to es6 this suffix will make no sense. And all legacy files should have a suffix.
The same for other scripts. If we going to ship es6 files as default then they should be called without suffix, and all legacy files should have a suffix. So in future we just drop "legacy" files without much trouble.
If we going to ship es6 files as default then they should be called without suffix, and all legacy files should have a suffix
Agreed. This way we will not repeat the odd -uncompressed.js/.js
thingy we had all over the place in J3.
One question is it possible to have a dependency loaded before core.js? If so how?
it possible to have a dependency loaded before core.js?
Not for regular script.
For inline it possible:
$wa->addInlineScript('alert("aaa!")', ['position' => 'before'], [], ['core']);
This kind of reverse dependency I guess. A couple people already asked about same, maybe need to think something in future for regulars script.
A couple people already asked about same, maybe need to think something in future for regulars script
Yeah, some array reordering function could be helpful. Anyways it turns out I don't need it here.
@wilsonge this should be almost the same behaviour as before:
It is correct order from how it configured.
if you want the legacy script to be after "wcpolyfill", then legacy script should have "wcpolyfill" dependency, main script does not require it .
Something like:
alert-legacy => depend from "wcpolyfill"
alert => depend from "alert-legacy"
btw, if you will use nomodule: true
then it should render attribute like nomodule
, instead of nomodule=""
. If not, then it a bug I guess.
Aha, I will fix the definitions later on today
It's completely unnecessary to add polyfills for IE support. IE is not supported as is. IE is also being completely discontinued (EOL) in August by Microsoft. This is a lot of extra work for something we can't even test (J4 frontend and backend do not work in IE) for a literal dead browser.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-28 10:34:17 |
Closed_By | ⇒ | wilsonge |
@wilsonge I think you a bit to fast here, @dgrammatiko still need to fix dependency issue
but can be done in another PR
I have tested this item✅ successfully on 9a0d464
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32171.