[#32170] - [4.0] Frontend module edit buttons needs a major styling cleanup
- Closed
- 20 Mar 2021
- Medium
- Build: staging
- # 32170
Steps to reproduce the issue
I think we slightly rushed the merge of #32070
At least on my macbook the buttons unfortunately overlap text and menu items in cases (I guess it might be better on larger screens)
Current view
The height of the buttons overlaps the title area - and looks scruffy. The buttons overlap text in some places (e.g. the menu - and that actually makes them unusable as the menu is on top of the button)
System information (as much as possible)
Chrome 87, 13 inch macbook
//cc @brianteeman
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
I am aware. But it got merged. And I don't believe there are followup issues to track improving the CSS/markup. So this adds it.
Well your direct commits are no better
Also true
The dilemma is that if we use absolute positioning, it always might overlap here or there because we can't know the look of every kind of module to provide styling for it, but if we use relative positioning so the edit buttons don't overlap anything, the modules need more space and so the look of the site may change much, compared to not edit mode.
A clean solution is adding the edit button to every module in the right place. No generic solution.
@brianteeman Is displaying the 'edit' text required?
@wilsonge Shall we fix the RTL issues mentioned by JM with the cleanup? Or shall we meanwhile make a PR just to fix RTL with what we have now, and do the cleanup after that?
@brianteeman Is displaying the 'edit' text required?
desired not required
I duplicated this report because I searched the tracker using Cassiopeia as a keyword an did not find anything relevant. Something that occurred to me later: It would be nice to have a master Toggle button to to toggle all the Edit buttons and links on/off.
It could be done like the accessibility plugin. But as we could end up with several of this type of thing we could group them together like the screenshot below. Then it is extendable by third parties as well
Sounds interesting - but implementing this is above my level in php/js. And not sure concerning B/C
| Labels |
Added:
?
|
||
rdeutz
- | Labels |
Removed:
?
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-20 11:31:21 |
| Closed_By | ⇒ | rdeutz |
As in the original PR I explicitly stated that it needed better css. I also stated that due to poor markup certain buttons were appearing in the wrong place. There was noting wrong with the PR. The problem with the css and markup existed before and I asked for assistance.