? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
24 Jan 2021

Pull Request for Issue #32135 .

Summary of Changes

Replace rm which is new and requires nodejs v14 to unlink

Testing Instructions

run npm install and check that the media/vendor/bootstrap/js has all the needed files there (the rm was removing a file index.es6.js

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 24 Jan 2021
avatar dgrammatiko dgrammatiko - change - 24 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2021
Category JavaScript Repository
avatar richard67
richard67 - comment - 24 Jan 2021

@dgrammatiko Just have tested this PR and it fixes the issue with rm. Now with the build script working, I get a lot of deprecation warnings when the atum template SCSS is compiled. Is that a know issue?

avatar richard67 richard67 - test_item - 24 Jan 2021 - Tested successfully
avatar richard67
richard67 - comment - 24 Jan 2021

I have tested this item successfully on 2f1ac43

Build succeeds now with nodejs version 12. Issue fixed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32143.

avatar dgrammatiko
dgrammatiko - comment - 24 Jan 2021

I get a lot of deprecation warnings when the atum template SCSS is compiled. Is that a known issue?

Yup, there's an open issue for that from Brian

avatar richard67 richard67 - change - 24 Jan 2021
The description was changed
avatar richard67 richard67 - edited - 24 Jan 2021
avatar brianteeman
brianteeman - comment - 24 Jan 2021

Yup, there's an open issue for that from Brian

Not any more please test #32144

avatar HLeithner HLeithner - change - 24 Jan 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-24 14:20:40
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 24 Jan 2021
avatar HLeithner HLeithner - merge - 24 Jan 2021
avatar HLeithner
HLeithner - comment - 24 Jan 2021

Thx

Add a Comment

Login with GitHub to post a comment