User tests: Successful: Unsuccessful:
This PR implements the same methodology in JModelLegacy::getName
as JViewLegacy::getName
. Fixes tracker #29015
This fixes an error where you wouldn't be able to have a model named CarpenterModelRemodel
or RemodelModelModels
.
The methodology to determine the name has been in use in JViewLegacy::getName
for the past year without issue.
We need a JC tracker please Also do you have a dummy component for before and after testing. I really would rather like to avoid having to create my own component just to test this :/
There is a jc tracker with a demo component already.
Linked to right in the opening description.
facepalm Will get on it in a bit
Can't test this. The component is clearly built for 2.5 as it's using JModel/JController/JView - I changed the stuff to JModelLegacy etc. But then hit an sql error in the default view
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'LIMIT 0, 20' at line 6 SQL=SELECT a.*,uc.name AS editor,jos_trailer_uses_211639.title AS uses_title_211639 FROM `jos_trailer_models` AS a LEFT JOIN jos_users AS uc ON uc.id=a.checked_out LEFT JOIN jos_trailer_uses AS jos_trailer_uses_211639 ON jos_trailer_uses_211639.id = a.use WHERE (a.state IN (0, 1)) ORDER BY LIMIT 0, 20
Had a brief look couldn't see any obvious issues - so can you check what the issue is there please?
order by is empty!
Interesting :P Dunno why.
So I tried installing the component on 2.5 because it's basically the same code just throwing a JError rather than exception. But there there was an error before the patch and after the patch of:
Error loading component: com_trailersmodel, 1
So I'm gonna say this is an unsuccessful test
There's no such thing as "com_trailersmodel". It's "com_trailers" and you have to try to load the "models" view.
Index.php?option=com_trailers&view=models
Sent from my iPhone
On Mar 28, 2014, at 9:26 PM, George Wilson notifications@github.com wrote:
Interesting :P Dunno why.
So I tried installing the component on 2.5 because it's basically the same code just throwing a JError rather than exception. But there there was an error before the patch and after the patch of:
Error loading component: com_trailersmodel, 1
So I'm gonna say this is an unsuccessful test
—
Reply to this email directly or view it on GitHub.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-26 17:19:09 |
Labels |
Closing as there has been no activity on this as requested
Title |
|
Anyone interested?