Feeling Lucky
?
[#3211] - [#33147] Category metadata params are not checked in JViewCategory
- Closed
- 8 Aug 2014
- Medium
- Build: staging
- # 3211
- Diff
- radiant-tech:category-meta-params
- Foreign ID 33147
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Category metadesc, metakey and robots are stored in separate db fields and are not checked as part of $this->params in the prepareDocument() method.
Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33147
radiant-tech
- comment
- 28 Feb 2014
Thanks Roberto! Updated.
Bakual
- comment
- 28 Feb 2014
We so similar things with articles, if we follow that it would be:
- If menu item matches the current category, then menu item has higher priority.
- If menu item doesn't match the current category, then the category has higher priority.
It makes the code more complex however since you need to do checks for the view and id and probably even the component of the active menuitem.
radiant-tech
- comment
- 3 Mar 2014
I've updated the PR to check for the active menu item.
brianteeman
- comment
- 8 Aug 2014
Closed as per the comment on the tracker
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-08 14:26:23 |
I think menu metadata has higher priority over the category metadata. So the checks should be done in reverse mode. If the menu has metadata use them and if not use the category.
That way we also ensure we don't break backward compatibility.
Thanks!