? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 Jan 2021

Aria controls is used for some toggle buttons in mobile views as below
image
image

It is used to identify what the button controls. In these examples its the list of components and help items.

For it to work correctly then it must control an id and not a class.

This PR corrects a copy paste error to ensure that there is always a matching id

avatar brianteeman brianteeman - open - 20 Jan 2021
avatar brianteeman brianteeman - change - 20 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jan 2021
Category Administration com_admin com_config
avatar carcam carcam - test_item - 21 Jan 2021 - Tested successfully
avatar carcam
carcam - comment - 21 Jan 2021

I have tested this item successfully on 8c5a559

This patch adds id when in Articles:options for the extra new area and fixes the reference to the id in the Joomla Help Start Here page.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32094.

avatar BertaOctech BertaOctech - test_item - 21 Jan 2021 - Tested successfully
avatar BertaOctech
BertaOctech - comment - 21 Jan 2021

I have tested this item successfully on 8c5a559

Indeed the patch corrects the values of the aria-controls attribute for these two pages.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32094.

avatar Quy Quy - change - 21 Jan 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 21 Jan 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32094.

avatar wilsonge wilsonge - change - 21 Jan 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-21 23:09:24
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 21 Jan 2021
avatar wilsonge wilsonge - merge - 21 Jan 2021
avatar wilsonge
wilsonge - comment - 21 Jan 2021

Thanks!

avatar brianteeman
brianteeman - comment - 21 Jan 2021

thanks

Add a Comment

Login with GitHub to post a comment