[#32093] - [4.0] Label menu item title
- Fixed in Code Base
- 21 Jan 2021
- Medium
- Build: 4.0-dev
- # 32093
- Diff
- chmst:menu-item-title
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The labels for titles in view menu Item are not correct.
Testing Instructions
Open a Menu Item new or edit.
Actual result BEFORE applying this Pull Request
The label above the title field is "Menu Title"
Expected result AFTER applying this Pull Request
The label above the title field is " Title", the label in tab Link Type is now "Display Menu Item Title". #32093 (comment)
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
Personally I would just change it to "Title"
I agree here at this point.
But I've found another text which might have to be changed, too:
That text is shown here, see the red mark:
The corresponding help text at https://help.joomla.org/proxy?keyref=Help4.x:Menu_Item:_New_Item/en#Link_Type says:
Add Menu Title: (Yes/No). If the optional image is added, adds the menu title next to the image. Default is 'Yes'.
If I'm not completely wrong, it should be "menu item title" and not "menu title" at this point in both the language string and the help text.
I am not sure with "title".
In Options, the second field is named only "Title" - I don't know which title this is. If this also is the "menu item title", I would prefer to use this consequently.
In Options, the second field is named only "Title" - I don't know which title this is. If this also is the "menu item title", I would prefer to use this consequently.
In a category blog, that's the thing formerly called "Show Title". According to the help https://help.joomla.org/proxy?keyref=Help40:Menu_Item:_Category_Blog&lang=en#Options_Tab : "Whether or not to show the Article's Title.".
| Labels |
Added:
?
?
|
||
I have used now Menu Item Title. In this component there are so many titles, that I think this is better.
I have used now Menu Item Title. In this component there are so many titles, that I think this is better.
For the place which I've found that's absolutely right.
But the COM_MENUS_ITEM_FIELD_TITLE_LABEL text could be just "Title", like Brian suggested, so it's consistent with articles, categories, ...
To me it seems that text is only used for that title field where it's ok.
But the COM_MENUS_ITEM_FIELD_TITLE_LABEL text could be just "Title"
Agree
Democracy .. now it is only title.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32093.
@chmst Now it only needs to adjust the testing instructions to that last change and also extend them by the instructions to check the change before the last one, that one with the other text I had found (you may just link to my comment with the screenshot so testers can find it).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32093.
Needs modifications in Help.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32093.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32093.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-21 10:55:22 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
|
||
Thanks
Good spot.
Personally I would just change it to "Title"
Then it matches all the other components and also matches the column heading in the list of all menu items