[#32069] - [4.0] Showon init only once, public method Joomla.Showon.initialise()
- Fixed in Code Base
- 27 Jan 2021
- Medium
- Build: 4.0-dev
- # 32069
- Diff
- Fedik:showon-once
User tests: Successful: Unsuccessful:
Summary of Changes
Same as #32061
The code make sure that showon initialised only once, no mater how often Joomla.Showon.initilise was called.
Also add public Joomla.Showon.initilise (to be in sync with 3.10)
Testing Instructions
Apply path, run npm install
Make sure showon still works.
Example, go to global config change "Debug Language" on/off, should downup/hides "Language Display" field.
Also the field "Language Display" will have extra attribute data-showon-initialised
Actual result BEFORE applying this Pull Request
showon works,
the showon field do not have data-showon-initialised
Expected result AFTER applying this Pull Request
showon works,
the showon field do have data-showon-initialised attribute
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Title |
|
||||||
@Fedik please fix cs https://ci.joomla.org/joomla/joomla-cms/39281
done
I have tested this item
To be clear: it is the control-group div that contains data-showon-initialised.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32069.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-27 22:47:37 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on 1e2b0dd
@wilsonge this can be merged
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32069.