Feeling Lucky
?
[#32058] - [4] add missing and fix wrong includes in com_finder, and remove unset on undefined var
- Fixed in Code Base
- 16 Jan 2021
- Medium
- Build: 4.0-dev
- # 32058
- Diff
- PhilETaylor:addmissingincludes
User tests: Successful: Unsuccessful:
Code review
Add missing includes for docblock type hints
Correct incorrect type hint and include that too (FilterTable)
Remote $tokens from the unset as $tokens is not even set in this method and undefined at this time and place.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Title |
|
||||||
| Labels |
Added:
?
|
||
gostn
- comment
- 16 Jan 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32058.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-16 09:00:26 |
| Closed_By | ⇒ | HLeithner |
HLeithner
- comment
- 16 Jan 2021
Thanks
I have tested this item✅ successfully on ec614a9
Tested successfully in Beta7-dev of 16 January.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32058.