? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
15 Jan 2021

Core review

add missing include and alias

use PHPMailer\PHPMailer\Exception as phpmailerException;

which is used, and currently undefined, here:

catch (MailDisabledException | phpmailerException $exception)

avatar PhilETaylor PhilETaylor - open - 15 Jan 2021
avatar PhilETaylor PhilETaylor - change - 15 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jan 2021
Category Front End Plugins
avatar toivo toivo - test_item - 16 Jan 2021 - Tested successfully
avatar toivo
toivo - comment - 16 Jan 2021

I have tested this item successfully on 5e9ec0e

Tested successfully in Beta7-dev of 16 January.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32057.

avatar gostn gostn - test_item - 16 Jan 2021 - Tested successfully
avatar gostn
gostn - comment - 16 Jan 2021

I have tested this item successfully on 5e9ec0e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32057.

avatar alikon alikon - change - 16 Jan 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 16 Jan 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32057.

avatar HLeithner
HLeithner - comment - 16 Jan 2021

I would really be interested how @toivo and @gostn tested this.

thanks @PhilETaylor

avatar HLeithner HLeithner - change - 16 Jan 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-16 08:29:28
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 16 Jan 2021
avatar HLeithner HLeithner - merge - 16 Jan 2021
avatar toivo
toivo - comment - 16 Jan 2021

@HLeithner - code review: after the PR as applied the line that created the missing alias was there.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32057.

avatar HLeithner
HLeithner - comment - 16 Jan 2021

thx @toivo

Add a Comment

Login with GitHub to post a comment