Feeling Lucky
?
[#32055] - [4] Fix default value type does not match the given type
- Fixed in Code Base
- 16 Jan 2021
- Medium
- Build: 4.0-dev
- # 32055
- Diff
- PhilETaylor:correcttype
User tests: Successful: Unsuccessful:
Even though they are unused, the docblock states they should be integers, not strings.
Code review.
* @param integer $height The height of the popup. [UNUSED]
* @param integer $width The width of the popup. [UNUSED]
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
gostn
- comment
- 16 Jan 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32055.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 16 Jan 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32055.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-16 08:26:44 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 16 Jan 2021
thanks
I have tested this item✅ successfully on f77ecab
Tested successfully in Beta7-dev of 16 January.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32055.