Feeling Lucky
?
[#32054] - [4] Remove unset call as $xml is not set when here
- Fixed in Code Base
- 16 Jan 2021
- Medium
- Build: 4.0-dev
- # 32054
- Diff
- PhilETaylor:removeunset
User tests: Successful: Unsuccessful:
Remove unset call as $xml is not set when here
Code review.
$xml is only set in the nested foreach statement, and already unset before the return and continue within that.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-16 09:29:26 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 16 Jan 2021
Thanks btw
I'm wrong when I say that the $xml is unset automatically on return if not referenced to the object it self or used outside this function? Even the unset in the loop before continue look use less because the $xml will be reassigned in the next run.