I have tested this item ? unsuccessfully on f3b6f0e

The Modify button did not work at all.

The Categories of this RP include JavaScript and NPM Change. Does something special need to be done before or after the RP is applied in Joommla! Patch Tester? I do not use NPM.

Yes this one will need npm to test (or one of the prebuilt packs)

@wilsonge where can I download one of the prebuilt packs to test this PR?

@toivo on github

@toivo at end of this pr as always on github

@brianteeman @gostn thank you!

@brianteeman @gostn - installing that version is far too complicated: "Environment Setup Incomplete
It looks like you are trying to run Joomla! from our git repository. To do so requires you complete a couple of extra steps first."

@toivo you shouldn't get that - the entire point of that binary is that it has all the environment dependencies (npm + composer) installed. I'll look later.

After applying the patch and npm ci I could not get to see the smtp plain text password at all, before or after save. Is that expected? I did not test sending a test email.

After applying the patch and npm ci I could not get to see the smtp plain text password at all, before or after save. Is that expected? I did not test sending a test email.

yes that's expected, it's part of a security patch in j3

@brianteeman @gostn - installing that version is far too complicated: "Environment Setup Incomplete
It looks like you are trying to run Joomla! from our git repository. To do so requires you complete a couple of extra steps first."

Download https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/31999/downloads/38993/Joomla_4.0.0-beta7-dev+pr.31999-Development-Update_Package.zip and install it as update package to your j4 installation

alternative you can install the full installation package: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/31999/downloads/38993/Joomla_4.0.0-beta7-dev+pr.31999-Development-Full_Package.zip

@HLeithner thanks for those links!

I have tested this item ✅ successfully on 5b384f1

Tested successfully in Beta7-dev installed from Joomla_4.0.0-beta7-dev+pr.31999-Development-Full_Package.zip.

The Modify button works fine. The View Password button is not there but it is not needed, especially if it would change the functionality of the Sent Test Mail button in a way that is not obvious to an average webmaster.

I removed the eye button because it would only work if you enter a new password and would confuse people when they see no existing passwords. So the functionality would be very limited anyway. And I think disabling it if not modified and enable on modify could be more unexpected. ymmv

I have tested this item ✅ successfully on 5b384f1

RTC

Thanks!