[#3192] - [#30781] Small changes to jForm and jField to allow for repeatable form elements
- Closed
- 6 Mar 2015
- Medium
- Build: master
- # 3192
- Foreign ID 30781
I have encountered encountered several issues with the new repeatable field.
1) Its not possible to have multiple repeatable field on a administration page. Only the last one will work. This is becurse of the repeatable.js which is badly written and dosent allow to fields.
2) The fields thats inside the repeatable field is showing in a tab even tough the field has hidden as parameter.
3) The divs that created as popup when you click the button arent removed from the dom when you are finished saving data which can create memory leaks.
4) Its not possible to edit data when you have more than 4 fields inside the repeatable field on a smaler screen. (Not reponsive.)
5) I also want to suggest that the fields become sortable.
My suggestion is to completely rewrite the repeatable.js to support all of these issues.
Votes
Hi. I have a ton of work so i cant prioritize this type of work at the moment. Its not verry hard to fix. Its more about the time it takes to fix it. If i just had more time :) I hope you find someone. Becurse its neat function.
Not very hard if you have a level of javascript knowledge greater than mine :) no worries though. I'll do what I can to find people to work through these issues - so thanks for listing them :) :) As I say number 2 will be fixed in the 3.2.3 release due this week. But the rest are things we are going to have to work on.
Super :)
I have also checked and the divs that popup when you click the button are only ever created once. So no memory leak exists (number 3 on your list)
This solution seems to have an issue with the "media" field. It seems to work fine for the first item and then won't show the modal view for any repeated media items. Maybe the default param of the field (testRepeat) needs to be in place, but I had no luck regardless of what I tried. Any ideas anyone?
Sample:
You may blame the J!Tracker Application for transmitting this comment.
A further serious problem I've found is that the items duplicate in the pop-up, increasing logarithmically each time.
For example, I've just created a repeatable in a component config with three columns and created two entries. I've saved it and reladed the component config. Now when I press the Select button the first time I get two items (as expected). However, I press cancel in the model and press select and I get four. The next time I try this I get 16! I tried again but got bored counting rows. I didn't press "save" (thankfully), so nothing was stored.
This was tested on Firefox 27.0.1
You may blame the J!Tracker Application for transmitting this comment.
Any progress on point 1? I would really like to use this on multiple fields
How is the status on the issues i have posted?
| Title |
|
||||||
| Labels |
Removed:
?
|
||||||
| Category | ⇒ | JavaScript |
Hey guys,
Send in a pull request for the items you'd like. Joomla's a community-run project with open development, so don't wait on others to get code added to the core. Take the lead.
In case anyone needs a git guide, here's how:
http://docs.joomla.org/Git_for_Coders
Sorry I should have posted an update on this. We've made a large rewrite of repeatable.js for Joomla 3.4 (see #3574) this doesn't fix the responsive nature of the fields - and I think there are still editors with certain modal/nested field types. However it makes these fields completely usable for 'standard' fields (e.g. text, list, radio etc).
Can this be closed now as "handled elsewhere" ?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3192.
| Status | New | ⇒ | Information Required |
| Labels |
Added:
?
|
||
After over two months without response for the requested information I am closing this issue at this time. It can always be reopened if further information is provided as had been requested.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3192.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-06 00:24:55 |
| Closed_By | ⇒ | brianteeman |
| Closed_Date | 2015-03-06 00:24:55 | ⇒ | 2015-03-06 00:24:56 |
Hi Number 2 is already fixed in master (see 9c3931d)
However if you want to volunteer to rewrite the JS feel free. I'm really struggling to find anyone with any JS know how on the project just to fix the simple bugs such as no. 3.