? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 Jan 2021

Menu items are displayed differently to plugins in the ordering field. This PR makes the display consistently and at the same time fixes a UX issue whereby the numbers displayed can become non-contigious.

Before

Plugin ordering (editors-xtd)

image
Note the numbers. the first is always 0 and the last is always +1 but as the numbers are displayed from the database we can easily end up with two 0 entries and nothing between 3 and 6. The numbers are not important.

Menu item ordering

image

After

Plugin ordering (editors-xtd)

image

avatar brianteeman brianteeman - open - 3 Jan 2021
avatar brianteeman brianteeman - change - 3 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2021
Category Libraries
avatar brianteeman brianteeman - change - 3 Jan 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2021
Category Libraries Administration Language & Strings Libraries
avatar toivo
toivo - comment - 4 Jan 2021

I have tested this item successfully on fc84344

Tested successfully in Beta6-dev of 4 January.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31850.

avatar toivo toivo - test_item - 4 Jan 2021 - Tested successfully
avatar gostn
gostn - comment - 4 Jan 2021

I have tested this item successfully on fc84344


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31850.

avatar gostn gostn - test_item - 4 Jan 2021 - Tested successfully
avatar richard67 richard67 - change - 4 Jan 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 4 Jan 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31850.

avatar ceford
ceford - comment - 4 Jan 2021

For the editors-xtd type the ordering displayed in the table, with Ordering Ascending selected, is not the same as the ordering seen when selecting one item to edit. I find that confusing!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31850.

avatar richard67
richard67 - comment - 13 Jan 2021

For the editors-xtd type the ordering displayed in the table, with Ordering Ascending selected, is not the same as the ordering seen when selecting one item to edit. I find that confusing!

@ceford Do I understand right that this issue is not related to this PR? If so: @brianteeman Do you think you can make another PR to fix that, too?

avatar richard67 richard67 - change - 13 Jan 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-13 18:21:11
Closed_By richard67
Labels Added: ? ?
avatar richard67 richard67 - close - 13 Jan 2021
avatar richard67 richard67 - merge - 13 Jan 2021
avatar richard67
richard67 - comment - 13 Jan 2021

Thanks!

avatar brianteeman
brianteeman - comment - 13 Jan 2021

The order of the xtd-editor plugins in the editor is unrelated to the order in the plugin manager.

avatar brianteeman
brianteeman - comment - 13 Jan 2021

Thanks for merging

Add a Comment

Login with GitHub to post a comment