[#31849] - Set result description even if introtext or fulltext is missing
- Closed
- 12 Jun 2022
- Medium
- Build: staging
- # 31849
- Diff
- kuehn-innerste:staging
User tests: Successful: Unsuccessful:
Pull Request for Issue [#31848]
Summary of Changes
The given code expects introtext AND fulltext both be present for a result description to be presented in search results. My patch loosens this requirement.
Testing Instructions
- create an article with the title "Hello finder", without introtext but with fulltext that contains several random sentences and the word "foobar"
- call php cli/finder_indexer.php
- search for "foobar"
Actual result BEFORE applying this Pull Request
Title of the article without description text.
Expected result AFTER applying this Pull Request
Title of the article with description text.
Documentation Changes Required
Nothing I know of.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
| Title |
|
||||||
| Title |
|
||||||
I have tested this item
Tested successfully in 3.9.24-rc of 4 January using PHP 7.4.13.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31849.
I'm sorry, but I can't support this. First of all, the summary and body attributes don't need to contain introtext and fulltext. You can use it for whatever you need/have. Second, there is also the description attribute, which is uses in your case. And third, I fear that this will disclose information which people expect to be hidden in certain situations.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31849.
The prebuilt package isn't found on https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/31849/downloads/38742.
The prebuilt package isn't found on https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/31849/downloads/38742.
@sandramay0905 The reason is that after a while, the packages are deleted, and it's a while ago when this PR has been built last time. A rebuild of the packages could be triggered e.g. by updating the branch for this PR to latest staging, which the author or a maintainer can do. But there is an unanswered comment that this PR might be wrong, see #31849 (comment) .
@Hackwar Could you check and answer my question above? #31849 (comment)
I have tested this item
Test by using patchtester.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31849.
@richard67 if you want the text to show up, you would have to fix this during indexing. But this is something that clashes with how other websites use it, so this would be done as a site specific change.
The old situation leads to the result, that in the search result list some results have a description built from the content, and some have no description, although there is body text, since the introtext is not set in the content. This gives an unexpected behaviour for the regular finder user. He would wonder why he has content everywhere but it is displayed only sometimes (=> when the introtext is set).
I'm sorry, but I can't support this. First of all, the summary and body attributes don't need to contain introtext and fulltext. You can use it for whatever you need/have.
You mean that someone using the indexer and connecting his content attribute fields with the indexer attribute fields (and then using this default file for displaying the search results) could use only one of the fields, summary OR body, and fill it with something that sould not be shown, being aware of the situation (or by coincidence) not using the other field? Because, if both fields are used, it would be displayed anyways.
Second, there is also the description attribute, which is uses in your case.
I don't see your point here, please explain.
And third, I fear that this will disclose information which people expect to be hidden in certain situations.
See my reply to your first point. Someone who wants to hide information would probably not put it into summary field if it will be displayed if there is something in the content in a search result.
I will close this PR here and not introduce an change within that behavior into j3.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-12 18:25:00 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
Information Required
?
|
||
@Hackwar Could you have a look on this? To me this PR seems to be correct, but I'm not the finder expert ;-)